Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add example of using mapping to parse array #5993

Merged
merged 1 commit into from Apr 23, 2018
Merged

Add example of using mapping to parse array #5993

merged 1 commit into from Apr 23, 2018

Conversation

esse
Copy link
Contributor

@esse esse commented Apr 23, 2018

Currently json documentation is missing a very common example of parsing array of objects using mapping.

This PR add this example into documentation (in section about using from_json).

@esse
Add example of using mapping to parse array
cb49ccc 
Currently json documentation is missing a very common example of parsing array of objects using mapping. 

This PR add this example into documentation (in section about using `from_json`).
@sdogruyol sdogruyol merged commit 1c4e4e8 into crystal-lang:master Apr 23, 2018
@esse esse deleted the patch-1 branch April 23, 2018 12:59
@paulcsmith
Copy link
Contributor

I've been wondering how to do this. Thanks, @esse!

@RX14 RX14 added this to the Next milestone Apr 25, 2018
chris-huxtable pushed a commit to chris-huxtable/crystal that referenced this pull request Jun 6, 2018
@esse @chris-huxtable
Add example of using mapping to parse array (crystal-lang#5993)
7023d5e 
Currently json documentation is missing a very common example of parsing array of objects using mapping. 

This PR add this example into documentation (in section about using `from_json`).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jhass jhass jhass approved these changes

@sdogruyol sdogruyol sdogruyol approved these changes

@wooster0 wooster0 wooster0 approved these changes

Assignees
No one assigned
Labels
kind:docs kind:feature topic:stdlib
Projects
None yet
Milestone
0.25.0
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@esse @paulcsmith @jhass @sdogruyol @wooster0 @RX14