Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

abootimg: init at 0.6 #39362

Merged
merged 1 commit into from Apr 28, 2018
Merged

abootimg: init at 0.6 #39362

merged 1 commit into from Apr 28, 2018

Conversation

flokli
Copy link
Contributor

@flokli flokli commented Apr 23, 2018

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: abootimg

Partial log (click to expand)

shrinking RPATHs of ELF executables and libraries in /nix/store/hjgzr3z5g7lmqf5hk18jylhhp16nsq77-abootimg-0.6
shrinking /nix/store/hjgzr3z5g7lmqf5hk18jylhhp16nsq77-abootimg-0.6/bin/abootimg
gzipping man pages under /nix/store/hjgzr3z5g7lmqf5hk18jylhhp16nsq77-abootimg-0.6/share/man/
strip is /nix/store/j75dgadrff2d1fyc4fczmcgqkid2imdx-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/hjgzr3z5g7lmqf5hk18jylhhp16nsq77-abootimg-0.6/bin
patching script interpreter paths in /nix/store/hjgzr3z5g7lmqf5hk18jylhhp16nsq77-abootimg-0.6
/nix/store/hjgzr3z5g7lmqf5hk18jylhhp16nsq77-abootimg-0.6/bin/.abootimg-pack-initrd-wrapped: interpreter directive changed from "/bin/sh" to "/nix/store/xn5gv3lpfy91yvfy9b0i7klfcxh9xskz-bash-4.4-p19/bin/sh"
/nix/store/hjgzr3z5g7lmqf5hk18jylhhp16nsq77-abootimg-0.6/bin/.abootimg-unpack-initrd-wrapped: interpreter directive changed from "/bin/sh" to "/nix/store/xn5gv3lpfy91yvfy9b0i7klfcxh9xskz-bash-4.4-p19/bin/sh"
checking for references to /build in /nix/store/hjgzr3z5g7lmqf5hk18jylhhp16nsq77-abootimg-0.6...
/nix/store/hjgzr3z5g7lmqf5hk18jylhhp16nsq77-abootimg-0.6

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: abootimg

Partial log (click to expand)

shrinking RPATHs of ELF executables and libraries in /nix/store/fsmwy29xskl1prxfsi574apivr13kwx1-abootimg-0.6
shrinking /nix/store/fsmwy29xskl1prxfsi574apivr13kwx1-abootimg-0.6/bin/abootimg
gzipping man pages under /nix/store/fsmwy29xskl1prxfsi574apivr13kwx1-abootimg-0.6/share/man/
strip is /nix/store/j7d4mr0ikv974ig7yzhknpsq288js4bs-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/fsmwy29xskl1prxfsi574apivr13kwx1-abootimg-0.6/bin
patching script interpreter paths in /nix/store/fsmwy29xskl1prxfsi574apivr13kwx1-abootimg-0.6
/nix/store/fsmwy29xskl1prxfsi574apivr13kwx1-abootimg-0.6/bin/.abootimg-unpack-initrd-wrapped: interpreter directive changed from "/bin/sh" to "/nix/store/adw9jx59wnrh5659wz43nbjya3m4b3gl-bash-4.4-p19/bin/sh"
/nix/store/fsmwy29xskl1prxfsi574apivr13kwx1-abootimg-0.6/bin/.abootimg-pack-initrd-wrapped: interpreter directive changed from "/bin/sh" to "/nix/store/adw9jx59wnrh5659wz43nbjya3m4b3gl-bash-4.4-p19/bin/sh"
checking for references to /build in /nix/store/fsmwy29xskl1prxfsi574apivr13kwx1-abootimg-0.6...
/nix/store/fsmwy29xskl1prxfsi574apivr13kwx1-abootimg-0.6

@GrahamcOfBorg
Copy link

Failure on x86_64-darwin (full log)

Attempted: abootimg

Partial log (click to expand)

building
build flags: SHELL=/nix/store/r8bx3qf1bpncb14i9gzma4vr089pc3pv-bash-4.4-p19/bin/bash
clang -O3 -Wall -DHAS_BLKID  -c -o abootimg.o abootimg.c
abootimg.c:51:10: fatal error: 'blkid/blkid.h' file not found
#include <blkid/blkid.h>
         ^~~~~~~~~~~~~~~
1 error generated.
make: *** [<builtin>: abootimg.o] Error 1
builder for '/nix/store/8s7rnh0lxh1c11y0x2i125gfwy0qkys4-abootimg-0.6.drv' failed with exit code 2
error: build of '/nix/store/8s7rnh0lxh1c11y0x2i125gfwy0qkys4-abootimg-0.6.drv' failed

@flokli
Copy link
Contributor Author

flokli commented Apr 23, 2018

right, blkid.h might not be available for darwin.

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: abootimg

Partial log (click to expand)

/nix/store/hjgzr3z5g7lmqf5hk18jylhhp16nsq77-abootimg-0.6

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: abootimg

Partial log (click to expand)

/nix/store/fsmwy29xskl1prxfsi574apivr13kwx1-abootimg-0.6

@GrahamcOfBorg
Copy link

No attempt on x86_64-darwin (full log)

The following builds were skipped because they don't evaluate on x86_64-darwin: abootimg

Partial log (click to expand)


a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowUnsupportedSystem = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowUnsupportedSystem = true; }
to ~/.config/nixpkgs/config.nix.

@xeji
Copy link
Contributor

xeji commented Apr 27, 2018

Upstream looks dead, code hasn't been updated since 2011. Are there no actively maintained alternatives?

@flokli
Copy link
Contributor Author

flokli commented Apr 27, 2018

For (re-)assembling images, mkbootimg from the Android project can be used, but I'm not aware of something "official" for extraction.
There's imgtool, but that's just a tarfile linked from its website.

@xeji
Copy link
Contributor

xeji commented Apr 28, 2018

Fine, if abootimg still works - the boot image format seems to be very stable 😄

@xeji xeji merged commit ac71615 into NixOS:master Apr 28, 2018
@flokli flokli deleted the abootimg branch May 2, 2018 13:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@flokli @GrahamcOfBorg @xeji