Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

singular: Fix ntl dependency #39370

Merged
merged 1 commit into from Apr 24, 2018
Merged

singular: Fix ntl dependency #39370

merged 1 commit into from Apr 24, 2018

Conversation

timokau
Copy link
Member

@timokau timokau commented Apr 23, 2018 •
edited

Motivation for this change

I added the ntl dependency in my recent PR (#38768). I failed to actually tell singular where to find it though, so its not used.

I'm pretty sure this worked for me before and I can't remember removing the --with-ntl line, but it doesn't find it now so I must've removed it some time.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@dotlambda
Copy link
Member

@GrahamcOfBorg build singular

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: singular

Partial log (click to expand)

// ** loaded /nix/store/pzvbd9cvqzpm0gffnza8w5hz1jpm4j5z-singular-4.1.1p1/bin/../share/singular/LIB/homolog.lib (4.1.1.0,Dec_2017)
// ** loaded /nix/store/pzvbd9cvqzpm0gffnza8w5hz1jpm4j5z-singular-4.1.1p1/bin/../share/singular/LIB/deform.lib (4.1.1.0,Feb_2018)
// ** loaded /nix/store/pzvbd9cvqzpm0gffnza8w5hz1jpm4j5z-singular-4.1.1p1/bin/../share/singular/LIB/gmssing.lib (4.1.1.0,Dec_2017)
// ** loaded /nix/store/pzvbd9cvqzpm0gffnza8w5hz1jpm4j5z-singular-4.1.1p1/bin/../share/singular/LIB/linalg.lib (4.1.1.0,Dec_2017)
// ** loaded /nix/store/pzvbd9cvqzpm0gffnza8w5hz1jpm4j5z-singular-4.1.1p1/bin/../share/singular/LIB/qhmoduli.lib (4.1.1.0,Dec_2017)
// ** loaded /nix/store/pzvbd9cvqzpm0gffnza8w5hz1jpm4j5z-singular-4.1.1p1/bin/../share/singular/LIB/rinvar.lib (4.1.1.0,Dec_2017)
// ** loaded /nix/store/pzvbd9cvqzpm0gffnza8w5hz1jpm4j5z-singular-4.1.1p1/bin/../share/singular/LIB/zeroset.lib (4.1.1.0,Dec_2017)
// ** loaded /nix/store/pzvbd9cvqzpm0gffnza8w5hz1jpm4j5z-singular-4.1.1p1/bin/../share/singular/LIB/primitiv.lib (4.1.1.0,Dec_2017)
Auf Wiedersehen.
/nix/store/pzvbd9cvqzpm0gffnza8w5hz1jpm4j5z-singular-4.1.1p1

@dotlambda
Copy link
Member

I just noticed the following line in the build log:

./configure: line 9572: /usr/bin/file: No such file or directory

Don't think that's a problem however.

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: singular

Partial log (click to expand)

// ** loaded /nix/store/pfq45fgdipvh68f9fhzcv0aw4rlkisxj-singular-4.1.1p1/bin/../share/singular/LIB/homolog.lib (4.1.1.0,Dec_2017)
// ** loaded /nix/store/pfq45fgdipvh68f9fhzcv0aw4rlkisxj-singular-4.1.1p1/bin/../share/singular/LIB/deform.lib (4.1.1.0,Feb_2018)
// ** loaded /nix/store/pfq45fgdipvh68f9fhzcv0aw4rlkisxj-singular-4.1.1p1/bin/../share/singular/LIB/gmssing.lib (4.1.1.0,Dec_2017)
// ** loaded /nix/store/pfq45fgdipvh68f9fhzcv0aw4rlkisxj-singular-4.1.1p1/bin/../share/singular/LIB/linalg.lib (4.1.1.0,Dec_2017)
// ** loaded /nix/store/pfq45fgdipvh68f9fhzcv0aw4rlkisxj-singular-4.1.1p1/bin/../share/singular/LIB/qhmoduli.lib (4.1.1.0,Dec_2017)
// ** loaded /nix/store/pfq45fgdipvh68f9fhzcv0aw4rlkisxj-singular-4.1.1p1/bin/../share/singular/LIB/rinvar.lib (4.1.1.0,Dec_2017)
// ** loaded /nix/store/pfq45fgdipvh68f9fhzcv0aw4rlkisxj-singular-4.1.1p1/bin/../share/singular/LIB/zeroset.lib (4.1.1.0,Dec_2017)
// ** loaded /nix/store/pfq45fgdipvh68f9fhzcv0aw4rlkisxj-singular-4.1.1p1/bin/../share/singular/LIB/primitiv.lib (4.1.1.0,Dec_2017)
Auf Wiedersehen.
/nix/store/pfq45fgdipvh68f9fhzcv0aw4rlkisxj-singular-4.1.1p1

@timokau
Copy link
Member Author

timokau commented Apr 24, 2018

Better safe than sorry, I fixed the warning.

@7c6f434c
Copy link
Member

@GrahamcOfBorg build singular

@GrahamcOfBorg
Copy link

No attempt on x86_64-darwin (full log)

The following builds were skipped because they don't evaluate on x86_64-darwin: singular

Partial log (click to expand)


a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowUnsupportedSystem = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowUnsupportedSystem = true; }
to ~/.config/nixpkgs/config.nix.

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: singular

Partial log (click to expand)

// ** loaded /nix/store/fivmprdswsmhp89kzpzs0bvg1awkm32m-singular-4.1.1p1/bin/../share/singular/LIB/homolog.lib (4.1.1.0,Dec_2017)
// ** loaded /nix/store/fivmprdswsmhp89kzpzs0bvg1awkm32m-singular-4.1.1p1/bin/../share/singular/LIB/deform.lib (4.1.1.0,Feb_2018)
// ** loaded /nix/store/fivmprdswsmhp89kzpzs0bvg1awkm32m-singular-4.1.1p1/bin/../share/singular/LIB/gmssing.lib (4.1.1.0,Dec_2017)
// ** loaded /nix/store/fivmprdswsmhp89kzpzs0bvg1awkm32m-singular-4.1.1p1/bin/../share/singular/LIB/linalg.lib (4.1.1.0,Dec_2017)
// ** loaded /nix/store/fivmprdswsmhp89kzpzs0bvg1awkm32m-singular-4.1.1p1/bin/../share/singular/LIB/qhmoduli.lib (4.1.1.0,Dec_2017)
// ** loaded /nix/store/fivmprdswsmhp89kzpzs0bvg1awkm32m-singular-4.1.1p1/bin/../share/singular/LIB/rinvar.lib (4.1.1.0,Dec_2017)
// ** loaded /nix/store/fivmprdswsmhp89kzpzs0bvg1awkm32m-singular-4.1.1p1/bin/../share/singular/LIB/zeroset.lib (4.1.1.0,Dec_2017)
// ** loaded /nix/store/fivmprdswsmhp89kzpzs0bvg1awkm32m-singular-4.1.1p1/bin/../share/singular/LIB/primitiv.lib (4.1.1.0,Dec_2017)
Auf Wiedersehen.
/nix/store/fivmprdswsmhp89kzpzs0bvg1awkm32m-singular-4.1.1p1

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: singular

Partial log (click to expand)

// ** loaded /nix/store/bqc34pizm4sk8rr0maidhqnf1v11r9qw-singular-4.1.1p1/bin/../share/singular/LIB/homolog.lib (4.1.1.0,Dec_2017)
// ** loaded /nix/store/bqc34pizm4sk8rr0maidhqnf1v11r9qw-singular-4.1.1p1/bin/../share/singular/LIB/deform.lib (4.1.1.0,Feb_2018)
// ** loaded /nix/store/bqc34pizm4sk8rr0maidhqnf1v11r9qw-singular-4.1.1p1/bin/../share/singular/LIB/gmssing.lib (4.1.1.0,Dec_2017)
// ** loaded /nix/store/bqc34pizm4sk8rr0maidhqnf1v11r9qw-singular-4.1.1p1/bin/../share/singular/LIB/linalg.lib (4.1.1.0,Dec_2017)
// ** loaded /nix/store/bqc34pizm4sk8rr0maidhqnf1v11r9qw-singular-4.1.1p1/bin/../share/singular/LIB/qhmoduli.lib (4.1.1.0,Dec_2017)
// ** loaded /nix/store/bqc34pizm4sk8rr0maidhqnf1v11r9qw-singular-4.1.1p1/bin/../share/singular/LIB/rinvar.lib (4.1.1.0,Dec_2017)
// ** loaded /nix/store/bqc34pizm4sk8rr0maidhqnf1v11r9qw-singular-4.1.1p1/bin/../share/singular/LIB/zeroset.lib (4.1.1.0,Dec_2017)
// ** loaded /nix/store/bqc34pizm4sk8rr0maidhqnf1v11r9qw-singular-4.1.1p1/bin/../share/singular/LIB/primitiv.lib (4.1.1.0,Dec_2017)
Auf Wiedersehen.
/nix/store/bqc34pizm4sk8rr0maidhqnf1v11r9qw-singular-4.1.1p1

@7c6f434c 7c6f434c merged commit bc6f7a9 into NixOS:master Apr 24, 2018
@timokau timokau deleted the singular-ntl branch April 24, 2018 11:29
@timokau timokau mentioned this pull request Aug 21, 2018
Closed
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@timokau @dotlambda @GrahamcOfBorg @7c6f434c