Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Coverage options support (2.5) #5147

Open
headius opened this issue Apr 23, 2018 · 3 comments
Open

Coverage options support (2.5) #5147

headius opened this issue Apr 23, 2018 · 3 comments
Labels
core help wanted ir jit parser

Comments

@headius
Copy link
Member

headius commented Apr 23, 2018

To move forward with JRuby 9.2 I have tagged off the new Coverage options tests (lines, branches, methods). We still need to implement this for 2.5 compatibility, but it is being reduced in priority.

The excludes:

exclude :test_branch_coverage_for_case_statement, "no support for coverage options yet"
exclude :test_branch_coverage_for_if_statement, "no support for coverage options yet"
exclude :test_branch_coverage_for_safe_method_invocation, "no support for coverage options yet"
exclude :test_branch_coverage_for_while_statement, "no support for coverage options yet"
exclude :test_line_coverage_for_multiple_lines, "no support for coverage options yet"
exclude :test_method_coverage, "no support for coverage options yet"
exclude :test_method_coverage_for_alias, "no support for coverage options yet"
exclude :test_method_coverage_for_define_method, "no support for coverage options yet"
exclude :test_method_coverage_for_singleton_class, "no support for coverage options yet"
@headius headius added this to the JRuby 9.2.0.0 milestone Apr 23, 2018
headius added a commit that referenced this issue Apr 23, 2018
@headius
Exclude Coverage tests related to new lines/branches/methods.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
GPG key ID: 4AEE18F83AFDEB23
Expired
Verified
Learn about vigilant mode
c76db3c 
See #5147.
@enebo enebo modified the milestones: JRuby 9.2.0.0, JRuby 9.2.1.0 May 24, 2018
@headius headius modified the milestones: JRuby 9.2.1.0, JRuby 9.3.0.0 Oct 26, 2018
@PragTob
Copy link

PragTob commented Dec 21, 2019

👋

Just chiming in that I'm finally adding branch coverage support to simplecov. No pressure though has/is taking us long enough and honesty I don't think it's that much of a killer feature but people want it :)

@headius
Copy link
Member Author

headius commented Jan 8, 2020

I'm not sure what's required for us to support it. @enebo you have looked at event hook stuff recently, did you happen to see how the new coverage options work?

@headius headius mentioned this issue Apr 1, 2020
Open
@headius headius modified the milestones: JRuby 9.3.0.0, JRuby 9.3.1.0 Jul 1, 2021
@headius headius modified the milestones: JRuby 9.3.1.0, JRuby 9.4.0.0 Oct 8, 2021
@headius
Copy link
Member Author

headius commented Oct 11, 2021

Nobody is jumping on this or other tracing-related issues so we are untargeting. Help wanted!

@headius headius removed this from the JRuby 9.4.0.0 milestone Oct 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
core help wanted ir jit parser
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@headius @enebo @PragTob