New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

go-jira: init at 1.0.17 #39363

Merged

nlewo merged 1 commit into NixOS:master from carlosdagos:go-jira-1.0.17

Apr 24, 2018

Member

carlosdagos commented Apr 23, 2018 •

edited

Motivation for this change

I borked up #26240 (sorry, I clearly need to learn how to git) where I didn't list any motivations. It's just a nice-enough program.

Things done

Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
Built on platform(s)
- NixOS
- macOS
- other Linux distributions
Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
Tested execution of all binary files (usually in ./result/bin/)
[] Fits CONTRIBUTING.md.

Additionally, this is an updated version to what was intended in the previous PR at #26240.

nlewo requested changes

View reviewed changes

pkgs/applications/misc/go-jira/default.nix Outdated

    
            @@ -0,0 +1,22 @@
          
              # This file was generated by https://github.com/kamilchm/go2nix v1.2.1

              { stdenv, buildGoPackage, fetchgit, fetchhg, fetchbzr, fetchsvn }:

Member

nlewo Apr 23, 2018

Could you remove useless attributes?

pkgs/applications/misc/go-jira/default.nix Outdated

    
                  sha256 = "0ap5dzikp934mawigmv7ighajr5yxpck2gpnb2cmkc1p6qa6gn4v";

                };

                meta = {

Member

nlewo Apr 23, 2018

Would you like to become the maintener of this packet? In this case, could you add yourself to the maintainers list?

pkgs/applications/misc/go-jira/default.nix Outdated

    
              { stdenv, buildGoPackage, fetchgit, fetchhg, fetchbzr, fetchsvn }:

              buildGoPackage rec {

                name = "go-jira-v1-${version}";

Member

nlewo Apr 23, 2018

I think the name should be go-jira-${version}.

pkgs/applications/misc/go-jira/default.nix Outdated

    
                goPackagePath = "gopkg.in/Netflix-Skunkworks/go-jira.v1";

                src = fetchgit {

Member

nlewo Apr 23, 2018

Could you use the tag as rev? Something such as rev = "v${version}".

Member Author

carlosdagos commented Apr 23, 2018

Thanks for reviewing @nlewo. I've added the changes as you suggested and added myself as a maintainer.

GrahamcOfBorg added 8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 labels

nlewo reviewed

View reviewed changes

pkgs/applications/misc/go-jira/default.nix Outdated

    
              buildGoPackage rec {

                name = "go-jira-${version}";

                version = "1.0.17";

                rev = "b98da3612d6ab0f3872b64ff36e6cf93219fb4d4";

Member

nlewo Apr 23, 2018

rev is then useless

Member Author

carlosdagos Apr 24, 2018

Thanks @nlewo :) This has been amended now.

Member

nlewo commented Apr 24, 2018

@carlosdagos Thanks. One last thing, can you squash your commits and remove (using go2nix) from your commit message?


          go-jira: init at 1.0.17

49f02db

carlosdagos force-pushed the go-jira-1.0.17 branch from 2a4b488 to 49f02db Compare

April 24, 2018 13:42

Member Author

carlosdagos commented Apr 24, 2018

Sure thing @nlewo. All done now :)

carlosdagos changed the title ~~go-jira: init at 1.0.17 (using go2nix)~~ go-jira: init at 1.0.17

Member

nlewo commented Apr 24, 2018

@GrahamcOfBorg build go-jira

GrahamcOfBorg commented Apr 24, 2018

Success on x86_64-linux (full log)

Attempted: go-jira

Partial log (click to expand)

/nix/store/yn7b42inhdn68n4ds21423p5pnnnz55l-go-jira-1.0.17/share/go/src/gopkg.in/Netflix-Skunkworks/go-jira.v1/t/200scrum.t: interpreter directive changed from "/bin/bash" to "/nix/store/xn5gv3lpfy91yvfy9b0i7klfcxh9xskz-bash-4.4-p19/bin/bash"
/nix/store/yn7b42inhdn68n4ds21423p5pnnnz55l-go-jira-1.0.17/share/go/src/gopkg.in/Netflix-Skunkworks/go-jira.v1/t/140basic-attach.t: interpreter directive changed from "/bin/bash" to "/nix/store/xn5gv3lpfy91yvfy9b0i7klfcxh9xskz-bash-4.4-p19/bin/bash"
/nix/store/yn7b42inhdn68n4ds21423p5pnnnz55l-go-jira-1.0.17/share/go/src/gopkg.in/Netflix-Skunkworks/go-jira.v1/t/400project.t: interpreter directive changed from "/bin/bash" to "/nix/store/xn5gv3lpfy91yvfy9b0i7klfcxh9xskz-bash-4.4-p19/bin/bash"
/nix/store/yn7b42inhdn68n4ds21423p5pnnnz55l-go-jira-1.0.17/share/go/src/gopkg.in/Netflix-Skunkworks/go-jira.v1/t/120custom-commands.t: interpreter directive changed from "/bin/bash" to "/nix/store/xn5gv3lpfy91yvfy9b0i7klfcxh9xskz-bash-4.4-p19/bin/bash"
/nix/store/yn7b42inhdn68n4ds21423p5pnnnz55l-go-jira-1.0.17/share/go/src/gopkg.in/Netflix-Skunkworks/go-jira.v1/t/000setup.t: interpreter directive changed from "/bin/bash" to "/nix/store/xn5gv3lpfy91yvfy9b0i7klfcxh9xskz-bash-4.4-p19/bin/bash"
/nix/store/yn7b42inhdn68n4ds21423p5pnnnz55l-go-jira-1.0.17/share/go/src/gopkg.in/Netflix-Skunkworks/go-jira.v1/t/100basic.t: interpreter directive changed from "/bin/bash" to "/nix/store/xn5gv3lpfy91yvfy9b0i7klfcxh9xskz-bash-4.4-p19/bin/bash"
/nix/store/yn7b42inhdn68n4ds21423p5pnnnz55l-go-jira-1.0.17/share/go/src/gopkg.in/Netflix-Skunkworks/go-jira.v1/vendor/golang.org/x/sys/unix/mkall.sh: interpreter directive changed from "/usr/bin/env bash" to "/nix/store/xn5gv3lpfy91yvfy9b0i7klfcxh9xskz-bash-4.4-p19/bin/bash"
/nix/store/yn7b42inhdn68n4ds21423p5pnnnz55l-go-jira-1.0.17/share/go/src/gopkg.in/Netflix-Skunkworks/go-jira.v1/vendor/golang.org/x/sys/unix/mkerrors.sh: interpreter directive changed from "/usr/bin/env bash" to "/nix/store/xn5gv3lpfy91yvfy9b0i7klfcxh9xskz-bash-4.4-p19/bin/bash"
checking for references to /build in /nix/store/yn7b42inhdn68n4ds21423p5pnnnz55l-go-jira-1.0.17...
/nix/store/scfil8ydy0q3rz3qgss05gppjgy7ai18-go-jira-1.0.17-bin

GrahamcOfBorg commented Apr 24, 2018

Success on aarch64-linux (full log)

Attempted: go-jira

Partial log (click to expand)

/nix/store/s9k078n256vg5i6427s0bgqc530s6f4f-go-jira-1.0.17/share/go/src/gopkg.in/Netflix-Skunkworks/go-jira.v1/t/140basic-attach.t: interpreter directive changed from "/bin/bash" to "/nix/store/adw9jx59wnrh5659wz43nbjya3m4b3gl-bash-4.4-p19/bin/bash"
/nix/store/s9k078n256vg5i6427s0bgqc530s6f4f-go-jira-1.0.17/share/go/src/gopkg.in/Netflix-Skunkworks/go-jira.v1/t/200scrum.t: interpreter directive changed from "/bin/bash" to "/nix/store/adw9jx59wnrh5659wz43nbjya3m4b3gl-bash-4.4-p19/bin/bash"
/nix/store/s9k078n256vg5i6427s0bgqc530s6f4f-go-jira-1.0.17/share/go/src/gopkg.in/Netflix-Skunkworks/go-jira.v1/t/300kanban.t: interpreter directive changed from "/bin/bash" to "/nix/store/adw9jx59wnrh5659wz43nbjya3m4b3gl-bash-4.4-p19/bin/bash"
/nix/store/s9k078n256vg5i6427s0bgqc530s6f4f-go-jira-1.0.17/share/go/src/gopkg.in/Netflix-Skunkworks/go-jira.v1/t/400project.t: interpreter directive changed from "/bin/bash" to "/nix/store/adw9jx59wnrh5659wz43nbjya3m4b3gl-bash-4.4-p19/bin/bash"
/nix/store/s9k078n256vg5i6427s0bgqc530s6f4f-go-jira-1.0.17/share/go/src/gopkg.in/Netflix-Skunkworks/go-jira.v1/t/500process.t: interpreter directive changed from "/bin/bash" to "/nix/store/adw9jx59wnrh5659wz43nbjya3m4b3gl-bash-4.4-p19/bin/bash"
/nix/store/s9k078n256vg5i6427s0bgqc530s6f4f-go-jira-1.0.17/share/go/src/gopkg.in/Netflix-Skunkworks/go-jira.v1/t/600task.t: interpreter directive changed from "/bin/bash" to "/nix/store/adw9jx59wnrh5659wz43nbjya3m4b3gl-bash-4.4-p19/bin/bash"
/nix/store/s9k078n256vg5i6427s0bgqc530s6f4f-go-jira-1.0.17/share/go/src/gopkg.in/Netflix-Skunkworks/go-jira.v1/vendor/golang.org/x/sys/unix/mkall.sh: interpreter directive changed from "/usr/bin/env bash" to "/nix/store/adw9jx59wnrh5659wz43nbjya3m4b3gl-bash-4.4-p19/bin/bash"
/nix/store/s9k078n256vg5i6427s0bgqc530s6f4f-go-jira-1.0.17/share/go/src/gopkg.in/Netflix-Skunkworks/go-jira.v1/vendor/golang.org/x/sys/unix/mkerrors.sh: interpreter directive changed from "/usr/bin/env bash" to "/nix/store/adw9jx59wnrh5659wz43nbjya3m4b3gl-bash-4.4-p19/bin/bash"
checking for references to /build in /nix/store/s9k078n256vg5i6427s0bgqc530s6f4f-go-jira-1.0.17...
/nix/store/93lk5ls7wjfvjcc6c2smd93abn8b6wfb-go-jira-1.0.17-bin

Member

nlewo commented Apr 24, 2018

@carlosdagos Thanks!

nlewo merged commit e095629 into NixOS:master

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment