Skip to content
This repository was archived by the owner on Apr 12, 2021. It is now read-only.
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: NixOS/nixpkgs-channels
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: 54b90e5f96c0
Choose a base ref
...
head repository: NixOS/nixpkgs-channels
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: b30c6d795035
Choose a head ref
  • 6 commits
  • 4 files changed
  • 6 contributors

Commits on May 3, 2018

  1. vim-utils: update plugin generation instruction

    Currently the pager is a problem but in general fetching
    all these plugins is inefficient for the general case.
    Ben Creasy committed May 3, 2018
    Copy the full SHA
    d981469 View commit details
  2. Verified

    This commit was signed with the committer’s verified signature.
    fpletz Franz Pletz
    Copy the full SHA
    4d6a14e View commit details
  3. vulnix: 1.6.1 -> 1.6.3

    Christian Kauhaus committed May 3, 2018
    Copy the full SHA
    46aa520 View commit details
  4. Merge pull request #39906 from jcrben/update-vim-plugin-generation-in…

    …structions
    
    vim-utils: update plugin generation instruction
    Mic92 authored May 3, 2018

    Verified

    This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
    Copy the full SHA
    42b5943 View commit details
  5. fetchs3: allow to name the derivation output (#39823)

    * fetchs3: add configurable name
    
    Change the default from "foo" to the basename of the s3 URL and make it
    configurable.
    
    * fetchs3: fix error on missing credentials.session_token
    
    The session token should default to null instead of failing
    
    * fetchs3: make use of the region argument
    
    Set it to null if you don't want to use it
    
    * fetchs3: prefer local build
    
    Fetcher-types spend more time on network than CPU
    zimbatm authored May 3, 2018

    Verified

    This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
    Copy the full SHA
    f7abcb0 View commit details
  6. Merge pull request #39912 from ckauhaus/vulnix-1.6.3

    vulnix: 1.6.1 -> 1.6.3
    7c6f434c authored May 3, 2018

    Verified

    This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
    Copy the full SHA
    b30c6d7 View commit details
Showing with 20 additions and 10 deletions.
  1. +13 −5 pkgs/build-support/fetchs3/default.nix
  2. +3 −1 pkgs/misc/vim-plugins/default.nix
  3. +2 −2 pkgs/tools/misc/youtube-dl/default.nix
  4. +2 −2 pkgs/tools/security/vulnix/default.nix
18 changes: 13 additions & 5 deletions pkgs/build-support/fetchs3/default.nix
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
{ stdenvNoCC, runCommand, awscli }:

{ s3url
, name ? builtins.baseNameOf s3url
, sha256
, region ? "us-east-1"
, credentials ? null # Default to looking at local EC2 metadata service
@@ -10,16 +11,23 @@
}:

let
credentialAttrs = stdenvNoCC.lib.optionalAttrs (credentials != null) {
AWS_ACCESS_KEY_ID = credentials.access_key_id;
AWS_SECRET_ACCESS_KEY = credentials.secret_access_key;
AWS_SESSION_TOKEN = credentials.session_token ? null;
mkCredentials = { access_key_id, secret_access_key, session_token ? null }: {
AWS_ACCESS_KEY_ID = access_key_id;
AWS_SECRET_ACCESS_KEY = secret_access_key;
AWS_SESSION_TOKEN = session_token;
};
in runCommand "foo" ({

credentialAttrs = stdenvNoCC.lib.optionalAttrs (credentials != null) (mkCredentials credentials);
in runCommand name ({
nativeBuildInputs = [ awscli ];

outputHashAlgo = "sha256";
outputHash = sha256;
outputHashMode = if recursiveHash then "recursive" else "flat";

preferLocalBuild = true;

AWS_DEFAULT_REGION = region;
} // credentialAttrs) (if postFetch != null then ''
downloadedFile="$(mktemp)"
aws s3 cp ${s3url} $downloadedFile
4 changes: 3 additions & 1 deletion pkgs/misc/vim-plugins/default.nix
Original file line number Diff line number Diff line change
@@ -21,7 +21,9 @@ in
# TL;DR
# Add your plugin to ./vim-plugin-names
# Regenerate via `nix-shell -I nixpkgs=/path/to/your/local/fork -p vimPlugins.pluginnames2nix --command "vim-plugin-names-to-nix +'w result' +qall"`
# Copy the generated expression(s) into this file.
# Note: pluginnames2nix will fetch any plugins in the file; to speed up the process,
# update ./vim-plugin-names to contain only plugins which need generation
# Copy the generated expression(s) into this file from the ./result file.
# If plugin is complicated then make changes to ./vim2nix/additional-nix-code

# This attrs contains two sections:
4 changes: 2 additions & 2 deletions pkgs/tools/misc/youtube-dl/default.nix
Original file line number Diff line number Diff line change
@@ -16,11 +16,11 @@ with stdenv.lib;
buildPythonApplication rec {

pname = "youtube-dl";
version = "2018.04.25";
version = "2018.05.01";

src = fetchurl {
url = "https://yt-dl.org/downloads/${version}/${pname}-${version}.tar.gz";
sha256 = "17zxgwfcy7c6gdyxdgh02f5zi52gvmy0zpccfj6zjkhw5iqj1vbw";
sha256 = "1mpyqdyjip5a6nn8lj1kaaab4pj75js6i8qzgap8bmn0k46awb1n";
};

nativeBuildInputs = [ makeWrapper ];
4 changes: 2 additions & 2 deletions pkgs/tools/security/vulnix/default.nix
Original file line number Diff line number Diff line change
@@ -2,11 +2,11 @@

pythonPackages.buildPythonApplication rec {
pname = "vulnix";
version = "1.6.1";
version = "1.6.3";

src = pythonPackages.fetchPypi {
inherit pname version;
sha256 = "0j6v6phq3naqnpvzxxnynsyv9y7bhig1gzvg594qpknqgyzj16bf";
sha256 = "0ia71l0210dgcxf63bg07csx40nmpdghr4mszz91qrri7lsa5qqi";
};

buildInputs = [ ronn ];