Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pythonPackages.supervise_api: 0.4.0 -> 0.5.3 #39931

Merged
merged 1 commit into from May 4, 2018
Merged

pythonPackages.supervise_api: 0.4.0 -> 0.5.3 #39931

merged 1 commit into from May 4, 2018

Conversation

catern
Copy link
Contributor

@catern catern commented May 3, 2018

Upstream added tests, so we run those too now.

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • [] Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@catern catern requested a review from FRidh as a code owner May 3, 2018 15:02
@catern catern changed the title pythonPackages.supervise_api: 0.4.0 -> 0.5.0 pythonPackages.supervise_api: 0.4.0 -> 0.5.2 May 3, 2018
dotlambda
dotlambda reviewed May 4, 2018
View reviewed changes
pkgs/development/python-modules/supervise_api/default.nix Outdated
}:

buildPythonPackage rec {
pname = "supervise_api";
version = "0.4.0";
version = "0.5.2";

name = "${pname}-${version}";
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please drop this line.

@dotlambda
Copy link
Member

@GrahamcOfBorg build python2.pkgs.supervise_api python3.pkgs.supervise_api

@dotlambda
Copy link
Member

I think you should add platforms = lib.platforms.linux.

Is this actually a python module or is it simply an application invoked on the command line? In the latter case, it should be moved out of pythonPackages.

@GrahamcOfBorg
Copy link

Failure on x86_64-linux (full log)

Attempted: python2.pkgs.supervise_api, python3.pkgs.supervise_api

Partial log (click to expand)

test_pathlib_sigchld_sigign (supervise_api.tests.test_supervise.TestSupervise) ... ok
test_relpath (supervise_api.tests.test_supervise.TestSupervise) ... ok
test_setsid (supervise_api.tests.test_supervise.TestSupervise) ... ok
test_setsid_and_nohup (supervise_api.tests.test_supervise.TestSupervise) ... ok

----------------------------------------------------------------------
Ran 18 tests in 0.107s

OK
error: build of '/nix/store/bc5ys2ym9xyhgf10r44fl7spzw7cx25y-python2.7-supervise_api-0.5.2.drv' failed

@GrahamcOfBorg
Copy link

Failure on aarch64-linux (full log)

Attempted: python2.pkgs.supervise_api, python3.pkgs.supervise_api

Partial log (click to expand)

test_pathlib_sigchld_sigign (supervise_api.tests.test_supervise.TestSupervise) ... ok
test_relpath (supervise_api.tests.test_supervise.TestSupervise) ... ok
test_setsid (supervise_api.tests.test_supervise.TestSupervise) ... ok
test_setsid_and_nohup (supervise_api.tests.test_supervise.TestSupervise) ... ok

----------------------------------------------------------------------
Ran 18 tests in 1.279s

OK
�[31;1merror:�[0m build of '/nix/store/1dpdnnifcvsdin0sm34mw06xaxs6p1n6-python2.7-supervise_api-0.5.2.drv' failed

@catern
Copy link
Contributor Author

catern commented May 4, 2018

It inherits a Linux platform dependency from its dependency 'supervise'.

It is indeed a Python library, not a standalone application.

@dotlambda
Copy link
Member

dotlambda commented May 4, 2018 •
edited

It inherits a Linux platform dependency from its dependency 'supervise'.

I know it does, but being explcicit is sometimes better. It's up to you.

@dotlambda
Copy link
Member

Does this only support Python 3? In that case, you should add disabled = !isPy3k.

@catern
Copy link
Contributor Author

catern commented May 4, 2018

Nope, I just fixed the Py2 support with that latest update :)

@catern catern changed the title pythonPackages.supervise_api: 0.4.0 -> 0.5.2 pythonPackages.supervise_api: 0.4.0 -> 0.5.3 May 4, 2018
@dotlambda
Copy link
Member

@GrahamcOfBorg build python2.pkgs.supervise_api python3.pkgs.supervise_api

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: python2.pkgs.supervise_api, python3.pkgs.supervise_api

Partial log (click to expand)

test_relpath (supervise_api.tests.test_supervise.TestSupervise) ... ok
test_setsid (supervise_api.tests.test_supervise.TestSupervise) ... ok
test_setsid_and_nohup (supervise_api.tests.test_supervise.TestSupervise) ... ok

----------------------------------------------------------------------
Ran 18 tests in 0.112s

OK
/nix/store/4cqzx3m3d57sa9qq7x18zn2l5xxi4248-python2.7-supervise_api-0.5.3
/nix/store/6dy1k4nnwkc36blj57mg65msj2hk0k85-python3.6-supervise_api-0.5.3

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: python2.pkgs.supervise_api, python3.pkgs.supervise_api

Partial log (click to expand)

test_relpath (supervise_api.tests.test_supervise.TestSupervise) ... ok
test_setsid (supervise_api.tests.test_supervise.TestSupervise) ... ok
test_setsid_and_nohup (supervise_api.tests.test_supervise.TestSupervise) ... ok

----------------------------------------------------------------------
Ran 18 tests in 0.728s

OK
/nix/store/62rq40njfglci18yxm9gxpwd0ba2m91j-python2.7-supervise_api-0.5.3
/nix/store/zrldm90xiaql57kddpk9aap63q4xaq2s-python3.6-supervise_api-0.5.3

dotlambda
dotlambda reviewed May 4, 2018
View reviewed changes
pkgs/development/python-modules/supervise_api/default.nix Outdated
@@ -4,27 +4,25 @@
, supervise
, isPy3k
, whichcraft
, linuxfd
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One final thing: this seems to not be used.

@catern
pythonPackages.supervise_api: 0.4.0 -> 0.5.3
62855fc 
Upstream added tests, so we run those too now.
@dotlambda dotlambda merged commit bee495e into NixOS:master May 4, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dotlambda dotlambda dotlambda left review comments

@FRidh FRidh Awaiting requested review from FRidh

Assignees
No one assigned
Labels
6.topic: python 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@catern @dotlambda @GrahamcOfBorg