Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ruby: 2.3.6 -> 2.3.7, 2.4.3 -> 2.4.4, 2.5.0 -> 2.5.1 #39928

Merged
merged 2 commits into from May 4, 2018
Merged

Ruby: 2.3.6 -> 2.3.7, 2.4.3 -> 2.4.4, 2.5.0 -> 2.5.1 #39928

merged 2 commits into from May 4, 2018

Conversation

manveru
Copy link
Contributor

@manveru manveru commented May 3, 2018 •
edited

Motivation for this change

https://www.ruby-lang.org/en/news/2018/03/28/ruby-2-5-1-released/
https://www.ruby-lang.org/en/news/2018/03/28/ruby-2-4-4-released/
https://www.ruby-lang.org/en/news/2018/03/28/ruby-2-3-7-released/

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@manveru manveru requested a review from zimbatm as a code owner May 3, 2018 14:05
@vcunat vcunat added 1.severity: security 9.needs: port to stable A PR needs a backport to the stable release. labels May 3, 2018
@zimbatm
Copy link
Member

zimbatm commented May 3, 2018

@GrahamcOfBorg build ruby_2_3 ruby_2_4 ruby_2_5

@GrahamcOfBorg
Copy link

Failure on x86_64-darwin (full log)

Attempted: ruby_2_3, ruby_2_4, ruby_2_5

Partial log (click to expand)

/nix/store/8w6pi3r039shvkn0sprwg88bqwyla7ri-ruby-2.5.1/lib/libruby.2.5.1.dylib: fixing dylib
/nix/store/8w6pi3r039shvkn0sprwg88bqwyla7ri-ruby-2.5.1/lib/libruby.2.5.1.dylib: fixing dylib
/nix/store/8w6pi3r039shvkn0sprwg88bqwyla7ri-ruby-2.5.1/lib/libruby.2.5.1.dylib: fixing dylib
/nix/store/8w6pi3r039shvkn0sprwg88bqwyla7ri-ruby-2.5.1/lib/libruby.2.5.1.dylib: fixing dylib
/nix/store/8w6pi3r039shvkn0sprwg88bqwyla7ri-ruby-2.5.1/lib/libruby.2.5.1.dylib: fixing dylib
/nix/store/8w6pi3r039shvkn0sprwg88bqwyla7ri-ruby-2.5.1/lib/libruby.2.5.1.dylib: fixing dylib
/nix/store/8w6pi3r039shvkn0sprwg88bqwyla7ri-ruby-2.5.1/lib/libruby.2.5.1.dylib: fixing dylib
/nix/store/8w6pi3r039shvkn0sprwg88bqwyla7ri-ruby-2.5.1/lib/libruby.2.5.1.dylib: fixing dylib
/nix/store/8w6pi3r039shvkn0sprwg88bqwyla7ri-ruby-2.5.1/lib/libruby.2.5.1.dylib: fixing dylib
error: build of '/nix/store/r44jywbmcjwvqf9b9z6ih5kd6pl1cdfi-ruby-2.4.4.drv', '/nix/store/y3w7x2hh7wa55fmhn4f2vcypbalan9mm-ruby-2.3.7.drv' failed

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: ruby_2_3, ruby_2_4, ruby_2_5

Partial log (click to expand)

shrinking /nix/store/9w30mcrv361zpzqqjlp1ac3cfgcvz5qx-ruby-2.5.1/lib/ruby/2.5.0/x86_64-linux/strscan.so
shrinking /nix/store/9w30mcrv361zpzqqjlp1ac3cfgcvz5qx-ruby-2.5.1/lib/ruby/2.5.0/x86_64-linux/zlib.so
gzipping man pages under /nix/store/9w30mcrv361zpzqqjlp1ac3cfgcvz5qx-ruby-2.5.1/share/man/
strip is /nix/store/j75dgadrff2d1fyc4fczmcgqkid2imdx-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/9w30mcrv361zpzqqjlp1ac3cfgcvz5qx-ruby-2.5.1/lib  /nix/store/9w30mcrv361zpzqqjlp1ac3cfgcvz5qx-ruby-2.5.1/bin
patching script interpreter paths in /nix/store/9w30mcrv361zpzqqjlp1ac3cfgcvz5qx-ruby-2.5.1
checking for references to /build in /nix/store/9w30mcrv361zpzqqjlp1ac3cfgcvz5qx-ruby-2.5.1...
/nix/store/zafjdc6b6g4bxsdxbgamz75yyhwpgkqr-ruby-2.3.7
/nix/store/hmahgll2dvrf91ljaqg7acrb2yndka70-ruby-2.4.4
/nix/store/9w30mcrv361zpzqqjlp1ac3cfgcvz5qx-ruby-2.5.1

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: ruby_2_3, ruby_2_4, ruby_2_5

Partial log (click to expand)

shrinking /nix/store/7shrvbzy1z9ylc60yi4dacajq5xq0b50-ruby-2.4.4/lib/ruby/2.4.0/aarch64-linux/ripper.so
shrinking /nix/store/7shrvbzy1z9ylc60yi4dacajq5xq0b50-ruby-2.4.4/lib/ruby/2.4.0/aarch64-linux/socket.so
gzipping man pages under /nix/store/7shrvbzy1z9ylc60yi4dacajq5xq0b50-ruby-2.4.4/share/man/
strip is /nix/store/gp7fylxwn18b7pl2c18ks89hsiaxyfvf-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/7shrvbzy1z9ylc60yi4dacajq5xq0b50-ruby-2.4.4/lib  /nix/store/7shrvbzy1z9ylc60yi4dacajq5xq0b50-ruby-2.4.4/bin
patching script interpreter paths in /nix/store/7shrvbzy1z9ylc60yi4dacajq5xq0b50-ruby-2.4.4
checking for references to /build in /nix/store/7shrvbzy1z9ylc60yi4dacajq5xq0b50-ruby-2.4.4...
/nix/store/3i4x85p7sf1pb07kgasj19mjs2n3mgmk-ruby-2.3.7
/nix/store/7shrvbzy1z9ylc60yi4dacajq5xq0b50-ruby-2.4.4
/nix/store/876kfpdfr351k7yxcmz6f95z9jlp66xr-ruby-2.5.1

@manveru
Copy link
Contributor Author

manveru commented May 3, 2018

Seems like the darwin failure is:

linking miniruby
ld: framework not found Foundation
clang-5.0: error: linker command failed with exit code 1 (use -v to see invocation)
make: *** [Makefile:221: miniruby] Error 1
builder for '/nix/store/4ffqylmb1ak3zkhl062c4djksdza1sjc-ruby-2.3.7.drv' failed with exit code 2

not sure what's that about

@LnL7
Copy link
Member

LnL7 commented May 3, 2018

@manveru I guess this version conditional isn't correct. https://github.com/manveru/nixpkgs/blob/f99ded298f5b34437395cc739d52042b4dce3580/pkgs/development/interpreters/ruby/default.nix#L97

@LnL7
Copy link
Member

LnL7 commented May 4, 2018

@GrahamcOfBorg build ruby_2_3 ruby_2_4 ruby_2_5

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: ruby_2_3, ruby_2_4, ruby_2_5

Partial log (click to expand)

shrinking /nix/store/hmahgll2dvrf91ljaqg7acrb2yndka70-ruby-2.4.4/lib/libruby.so.2.4.4
shrinking /nix/store/hmahgll2dvrf91ljaqg7acrb2yndka70-ruby-2.4.4/bin/ruby
gzipping man pages under /nix/store/hmahgll2dvrf91ljaqg7acrb2yndka70-ruby-2.4.4/share/man/
strip is /nix/store/j75dgadrff2d1fyc4fczmcgqkid2imdx-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/hmahgll2dvrf91ljaqg7acrb2yndka70-ruby-2.4.4/lib  /nix/store/hmahgll2dvrf91ljaqg7acrb2yndka70-ruby-2.4.4/bin
patching script interpreter paths in /nix/store/hmahgll2dvrf91ljaqg7acrb2yndka70-ruby-2.4.4
checking for references to /build in /nix/store/hmahgll2dvrf91ljaqg7acrb2yndka70-ruby-2.4.4...
/nix/store/zafjdc6b6g4bxsdxbgamz75yyhwpgkqr-ruby-2.3.7
/nix/store/hmahgll2dvrf91ljaqg7acrb2yndka70-ruby-2.4.4
/nix/store/9w30mcrv361zpzqqjlp1ac3cfgcvz5qx-ruby-2.5.1

@GrahamcOfBorg
Copy link

Success on x86_64-darwin (full log)

Attempted: ruby_2_3, ruby_2_4, ruby_2_5

Partial log (click to expand)

/nix/store/kvhi4g2m2q9qwrq5s62a1jacr8cmk91c-ruby-2.4.4/lib/libruby.2.4.4.dylib: fixing dylib
/nix/store/kvhi4g2m2q9qwrq5s62a1jacr8cmk91c-ruby-2.4.4/lib/libruby.2.4.4.dylib: fixing dylib
/nix/store/kvhi4g2m2q9qwrq5s62a1jacr8cmk91c-ruby-2.4.4/lib/libruby.2.4.4.dylib: fixing dylib
/nix/store/kvhi4g2m2q9qwrq5s62a1jacr8cmk91c-ruby-2.4.4/lib/libruby.2.4.4.dylib: fixing dylib
/nix/store/kvhi4g2m2q9qwrq5s62a1jacr8cmk91c-ruby-2.4.4/lib/libruby.2.4.4.dylib: fixing dylib
/nix/store/kvhi4g2m2q9qwrq5s62a1jacr8cmk91c-ruby-2.4.4/lib/libruby.2.4.4.dylib: fixing dylib
/nix/store/kvhi4g2m2q9qwrq5s62a1jacr8cmk91c-ruby-2.4.4/lib/libruby.2.4.4.dylib: fixing dylib
/nix/store/zabxkadxi7a06pyykya6gg4z2c6cqabr-ruby-2.3.7
/nix/store/kvhi4g2m2q9qwrq5s62a1jacr8cmk91c-ruby-2.4.4
/nix/store/y51mqdkwg0snv5gkrap45adrwkag5x6z-ruby-2.5.1

LnL7
LnL7 approved these changes May 4, 2018
View reviewed changes
Copy link
Member

@LnL7 LnL7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the delay

@LnL7 LnL7 merged commit b5968f2 into NixOS:master May 4, 2018
@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: ruby_2_3, ruby_2_4, ruby_2_5

Partial log (click to expand)

shrinking /nix/store/7shrvbzy1z9ylc60yi4dacajq5xq0b50-ruby-2.4.4/lib/ruby/2.4.0/aarch64-linux/ripper.so
shrinking /nix/store/7shrvbzy1z9ylc60yi4dacajq5xq0b50-ruby-2.4.4/lib/ruby/2.4.0/aarch64-linux/socket.so
gzipping man pages under /nix/store/7shrvbzy1z9ylc60yi4dacajq5xq0b50-ruby-2.4.4/share/man/
strip is /nix/store/gp7fylxwn18b7pl2c18ks89hsiaxyfvf-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/7shrvbzy1z9ylc60yi4dacajq5xq0b50-ruby-2.4.4/lib  /nix/store/7shrvbzy1z9ylc60yi4dacajq5xq0b50-ruby-2.4.4/bin
patching script interpreter paths in /nix/store/7shrvbzy1z9ylc60yi4dacajq5xq0b50-ruby-2.4.4
checking for references to /build in /nix/store/7shrvbzy1z9ylc60yi4dacajq5xq0b50-ruby-2.4.4...
/nix/store/3i4x85p7sf1pb07kgasj19mjs2n3mgmk-ruby-2.3.7
/nix/store/7shrvbzy1z9ylc60yi4dacajq5xq0b50-ruby-2.4.4
/nix/store/876kfpdfr351k7yxcmz6f95z9jlp66xr-ruby-2.5.1

@LnL7
Copy link
Member

LnL7 commented May 4, 2018

Backported to 18.03 in 94a3649.

@LnL7 LnL7 added the 8.has: port to stable A PR already has a backport to the stable release. label May 4, 2018
@samueldr samueldr removed the 9.needs: port to stable A PR needs a backport to the stable release. label Apr 17, 2019
@manveru manveru deleted the update-ruby branch November 29, 2019 20:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LnL7 LnL7 LnL7 approved these changes

@zimbatm zimbatm Awaiting requested review from zimbatm

Assignees
No one assigned
Labels
1.severity: security 6.topic: ruby 8.has: port to stable A PR already has a backport to the stable release. 10.rebuild-darwin: 101-500 10.rebuild-linux: 101-500
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@manveru @zimbatm @GrahamcOfBorg @LnL7 @samueldr @vcunat