Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gcc7: Removed java as a target language #39924

Merged
merged 3 commits into from May 3, 2018
Merged

gcc7: Removed java as a target language #39924

merged 3 commits into from May 3, 2018

Conversation

Synthetica9
Copy link
Member

@Synthetica9 Synthetica9 commented May 3, 2018 •
edited

Motivation for this change

Retry of the... less than overwhelming success that #39917 was.

For your convenience:

As discussed in #39866

GCC6 is the last GCC release to support Java as a target language. I quote @gebner (#39866 (comment)):

I think we should remove them completely. AFAICT the only place where we override enableJava et al. is in the gcj6 attribute (which uses gcc6).

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@Synthetica9
Copy link
Member Author

CC @Profpatsch @xeji

@xeji
Copy link
Contributor

xeji commented May 3, 2018

Let's try once if we get ofborg to build this (may time out)

@GrahamcOfBorg build gcc7

@Synthetica9
Copy link
Member Author

Probably will time out, took more than an hour on my machine. (Doesn't ofborg give timeout messages btw?)

@xeji
Copy link
Contributor

xeji commented May 3, 2018

I think it does time out after 1hr.

@GrahamcOfBorg
Copy link

Failure on aarch64-linux (full log)

Attempted: gcc7

Partial log (click to expand)

cannot build derivation '/nix/store/bigafakb6jm4mnj2n8rbsghwxifmpxqx-perl-5.24.3.drv': 3 dependencies couldn't be built
cannot build derivation '/nix/store/dfxsyz4c918c1yaz8wkq7lx70r6k3lnc-which-2.21.drv': 2 dependencies couldn't be built
cannot build derivation '/nix/store/gwh4jlrk38gwn0z7il0sahvbss017kfm-gmp-6.1.2.drv': 4 dependencies couldn't be built
cannot build derivation '/nix/store/f8ysrhdpgm4c5pia4sklwmwm1j40z0fy-libelf-0.8.13.drv': 3 dependencies couldn't be built
cannot build derivation '/nix/store/8i9b54pa1823lsf9rms8p7isna95z59r-isl-0.17.1.drv': 3 dependencies couldn't be built
cannot build derivation '/nix/store/05nn4j905zvl1cdmfgsszmkza1i3f6zw-mpfr-4.0.1.drv': 3 dependencies couldn't be built
cannot build derivation '/nix/store/685wawb90iz32nbfnv3624dkbgymj7i1-libmpc-1.1.0.drv': 4 dependencies couldn't be built
cannot build derivation '/nix/store/1fpi6hbn3w81lx71zi4bbchljniy966d-gcc-7.3.0.drv': 13 dependencies couldn't be built
cannot build derivation '/nix/store/h7bk0h9xgklmbgjdljnlw140av4hsf6l-gcc-wrapper-7.3.0.drv': 7 dependencies couldn't be built
�[31;1merror:�[0m build of '/nix/store/h7bk0h9xgklmbgjdljnlw140av4hsf6l-gcc-wrapper-7.3.0.drv' failed

@Synthetica9
Copy link
Member Author

Is that just the timeout message?

@xeji
Copy link
Contributor

xeji commented May 3, 2018

No, some dependencies failed, seems unrelated to this PR.

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: gcc7

Partial log (click to expand)

no configure script, doing nothing
installing
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/3a0sxq113fr4jk996h2l10f4612m47p5-gcc-wrapper-7.3.0
strip is /nix/store/pjfm07gclyzz5csx7kqdr4ji2gjzwizk-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/3a0sxq113fr4jk996h2l10f4612m47p5-gcc-wrapper-7.3.0/bin
patching script interpreter paths in /nix/store/3a0sxq113fr4jk996h2l10f4612m47p5-gcc-wrapper-7.3.0
checking for references to /build in /nix/store/3a0sxq113fr4jk996h2l10f4612m47p5-gcc-wrapper-7.3.0...
strip is /nix/store/pjfm07gclyzz5csx7kqdr4ji2gjzwizk-binutils-2.30/bin/strip
strip is /nix/store/pjfm07gclyzz5csx7kqdr4ji2gjzwizk-binutils-2.30/bin/strip

@xeji xeji requested a review from abbradar May 3, 2018 15:46
@Ericson2314
Copy link
Member

Don't forget gcc-snapshot

@Synthetica9
Copy link
Member Author

@Ericson2314 ✔️

@Ericson2314 Ericson2314 merged commit cbe21ac into NixOS:staging May 3, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ericson2314 Ericson2314 Ericson2314 approved these changes

@abbradar abbradar Awaiting requested review from abbradar

Assignees
No one assigned
Labels
10.rebuild-darwin: 501+ 10.rebuild-linux: 501+ 10.rebuild-linux-stdenv
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@Synthetica9 @xeji @GrahamcOfBorg @Ericson2314