Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

glogg: init at 1.1.4 #39923

Closed
wants to merge 1 commit into from
Closed

glogg: init at 1.1.4 #39923

wants to merge 1 commit into from

Conversation

hlolli
Copy link
Member

@hlolli hlolli commented May 3, 2018

Motivation for this change

This is a fine large file explorer / log explorer which is missing.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • [ x ] NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • [ x ] Tested execution of all binary files (usually in ./result/bin/)
  • [ x ] Fits CONTRIBUTING.md.

Didn't test darwin, but if the test fail, I'll change the platform meta.

@nlewo
Copy link
Member

nlewo commented May 4, 2018

@GrahamcOfBorg build glogg

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: glogg

Partial log (click to expand)

glibPreFixupPhase
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/6nh4gfzq5fxww3g0p92hs4hr314kvm34-glogg-1.1.4
shrinking /nix/store/6nh4gfzq5fxww3g0p92hs4hr314kvm34-glogg-1.1.4/bin/glogg
strip is /nix/store/gp7fylxwn18b7pl2c18ks89hsiaxyfvf-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/6nh4gfzq5fxww3g0p92hs4hr314kvm34-glogg-1.1.4/bin
patching script interpreter paths in /nix/store/6nh4gfzq5fxww3g0p92hs4hr314kvm34-glogg-1.1.4
checking for references to /build in /nix/store/6nh4gfzq5fxww3g0p92hs4hr314kvm34-glogg-1.1.4...
postPatchMkspecs
/nix/store/6nh4gfzq5fxww3g0p92hs4hr314kvm34-glogg-1.1.4

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: glogg

Partial log (click to expand)

glibPreFixupPhase
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/zv0wn7wlw87q2jm355rbcnnc6zk7ykvz-glogg-1.1.4
shrinking /nix/store/zv0wn7wlw87q2jm355rbcnnc6zk7ykvz-glogg-1.1.4/bin/glogg
strip is /nix/store/j75dgadrff2d1fyc4fczmcgqkid2imdx-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/zv0wn7wlw87q2jm355rbcnnc6zk7ykvz-glogg-1.1.4/bin
patching script interpreter paths in /nix/store/zv0wn7wlw87q2jm355rbcnnc6zk7ykvz-glogg-1.1.4
checking for references to /build in /nix/store/zv0wn7wlw87q2jm355rbcnnc6zk7ykvz-glogg-1.1.4...
postPatchMkspecs
/nix/store/zv0wn7wlw87q2jm355rbcnnc6zk7ykvz-glogg-1.1.4

matthewbauer
matthewbauer reviewed May 7, 2018
View reviewed changes
pkgs/applications/misc/glogg/default.nix
qmakeFlags = [ "glogg.pro" ];

installCommand = ''
make install INSTALL_ROOT=$out
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think this will be run. installCommand is not used.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes that's right, I can delete it and it will work. Will update my PR.

@c0bw3b
Copy link
Contributor

c0bw3b commented Nov 17, 2018

Closing -> #50520

@c0bw3b c0bw3b closed this Nov 17, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matthewbauer matthewbauer matthewbauer left review comments

Assignees
No one assigned
Labels
2.status: merge conflict 8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@hlolli @nlewo @GrahamcOfBorg @c0bw3b @matthewbauer @samueldr @xeji