john: build with recent gcc #39929

Mic92 · 2018-05-03T14:25:40Z

Motivation for this change

john the ripper contains a patch for gcc >= 5 and builds fine. I am not sure why this was pinned in the first place.

Things done

Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
Built on platform(s)
- NixOS
- macOS
- other Linux distributions
Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
Tested execution of all binary files (usually in ./result/bin/)
Fits CONTRIBUTING.md.

Mic92 · 2018-05-03T14:26:10Z

@GrahamcOfBorg build john

GrahamcOfBorg · 2018-05-03T14:27:58Z

No attempt on x86_64-darwin (full log)

The following builds were skipped because they don't evaluate on x86_64-darwin: john

Partial log (click to expand)


a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowUnsupportedSystem = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowUnsupportedSystem = true; }
to ~/.config/nixpkgs/config.nix.

GrahamcOfBorg · 2018-05-03T14:40:34Z

No attempt on x86_64-darwin (full log)

The following builds were skipped because they don't evaluate on x86_64-darwin: john

Partial log (click to expand)


a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowUnsupportedSystem = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowUnsupportedSystem = true; }
to ~/.config/nixpkgs/config.nix.

GrahamcOfBorg · 2018-05-03T14:59:13Z

Failure on aarch64-linux (full log)

Attempted: john

Partial log (click to expand)

 extern size_t strlen (const char *__s)
               ^~~~~~
truecrypt_fmt_plug.c:314:95: error: 'num_iterations' undeclared (first use in this function)
    pbkdf2_sha512((const unsigned char*)key_buffer[i], strlen(key_buffer[i]), psalt->salt, 64, num_iterations, key, sizeof(key), 0);
                                                                                               ^~~~~~~~~~~~~~
make[1]: *** [Makefile:520: truecrypt_fmt_plug.o] Error 1
make[1]: Leaving directory '/build/john-1.8.0-jumbo-1/src'
make: *** [Makefile:185: default] Error 2
builder for '/nix/store/h4w2nw75xh967jsq8pi7x3hhbmla5aml-john-1.8.0-jumbo-1.drv' failed with exit code 2
�[31;1merror:�[0m build of '/nix/store/h4w2nw75xh967jsq8pi7x3hhbmla5aml-john-1.8.0-jumbo-1.drv' failed

GrahamcOfBorg · 2018-05-03T15:05:19Z

Failure on aarch64-linux (full log)

Attempted: john

Partial log (click to expand)

 extern size_t strlen (const char *__s)
               ^~~~~~
truecrypt_fmt_plug.c:314:95: error: 'num_iterations' undeclared (first use in this function)
    pbkdf2_sha512((const unsigned char*)key_buffer[i], strlen(key_buffer[i]), psalt->salt, 64, num_iterations, key, sizeof(key), 0);
                                                                                               ^~~~~~~~~~~~~~
make[1]: *** [Makefile:520: truecrypt_fmt_plug.o] Error 1
make[1]: Leaving directory '/build/john-1.8.0-jumbo-1/src'
make: *** [Makefile:185: default] Error 2
builder for '/nix/store/h4w2nw75xh967jsq8pi7x3hhbmla5aml-john-1.8.0-jumbo-1.drv' failed with exit code 2
�[31;1merror:�[0m build of '/nix/store/h4w2nw75xh967jsq8pi7x3hhbmla5aml-john-1.8.0-jumbo-1.drv' failed

GrahamcOfBorg · 2018-05-03T15:13:15Z

Success on x86_64-linux (full log)

Attempted: john

Partial log (click to expand)

wrapping `/nix/store/bh75rbc1i4r53inpryqlp0svjp7vy3ib-john-1.8.0-jumbo-1/bin/dmg2john.py'...
wrapping `/nix/store/bh75rbc1i4r53inpryqlp0svjp7vy3ib-john-1.8.0-jumbo-1/bin/sipdump2john.py'...
wrapping `/nix/store/bh75rbc1i4r53inpryqlp0svjp7vy3ib-john-1.8.0-jumbo-1/bin/kwallet2john.py'...
wrapping `/nix/store/bh75rbc1i4r53inpryqlp0svjp7vy3ib-john-1.8.0-jumbo-1/bin/keystore2john.py'...
wrapping `/nix/store/bh75rbc1i4r53inpryqlp0svjp7vy3ib-john-1.8.0-jumbo-1/bin/openssl2john.py'...
wrapping `/nix/store/bh75rbc1i4r53inpryqlp0svjp7vy3ib-john-1.8.0-jumbo-1/bin/7z2john.py'...
wrapping `/nix/store/bh75rbc1i4r53inpryqlp0svjp7vy3ib-john-1.8.0-jumbo-1/bin/cracf2john.py'...
wrapping `/nix/store/bh75rbc1i4r53inpryqlp0svjp7vy3ib-john-1.8.0-jumbo-1/bin/office2john.py'...
wrapping `/nix/store/bh75rbc1i4r53inpryqlp0svjp7vy3ib-john-1.8.0-jumbo-1/bin/htdigest2john.py'...
/nix/store/bh75rbc1i4r53inpryqlp0svjp7vy3ib-john-1.8.0-jumbo-1

GrahamcOfBorg · 2018-05-03T15:13:22Z

Success on x86_64-linux (full log)

Attempted: john

Partial log (click to expand)

/nix/store/bh75rbc1i4r53inpryqlp0svjp7vy3ib-john-1.8.0-jumbo-1

xeji · 2018-05-03T15:58:32Z

aarch64 failure is unrelated, I couldn't find any successful hydra build on aarch64 (looking back to March 2017). So let's exclude aarch64 for now.

Mic92 · 2018-05-03T16:08:41Z

@GrahamcOfBorg build john

GrahamcOfBorg · 2018-05-03T16:10:21Z

No attempt on x86_64-darwin (full log)

The following builds were skipped because they don't evaluate on x86_64-darwin: john

Partial log (click to expand)


a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowUnsupportedSystem = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowUnsupportedSystem = true; }
to ~/.config/nixpkgs/config.nix.

GrahamcOfBorg · 2018-05-03T16:14:27Z

Success on x86_64-linux (full log)

Attempted: john

Partial log (click to expand)

wrapping `/nix/store/bh75rbc1i4r53inpryqlp0svjp7vy3ib-john-1.8.0-jumbo-1/bin/kwallet2john.py'...
wrapping `/nix/store/bh75rbc1i4r53inpryqlp0svjp7vy3ib-john-1.8.0-jumbo-1/bin/ecryptfs2john.py'...
wrapping `/nix/store/bh75rbc1i4r53inpryqlp0svjp7vy3ib-john-1.8.0-jumbo-1/bin/encfs2john.py'...
wrapping `/nix/store/bh75rbc1i4r53inpryqlp0svjp7vy3ib-john-1.8.0-jumbo-1/bin/cracf2john.py'...
wrapping `/nix/store/bh75rbc1i4r53inpryqlp0svjp7vy3ib-john-1.8.0-jumbo-1/bin/efs2john.py'...
wrapping `/nix/store/bh75rbc1i4r53inpryqlp0svjp7vy3ib-john-1.8.0-jumbo-1/bin/pcap2john.py'...
wrapping `/nix/store/bh75rbc1i4r53inpryqlp0svjp7vy3ib-john-1.8.0-jumbo-1/bin/ml2john.py'...
wrapping `/nix/store/bh75rbc1i4r53inpryqlp0svjp7vy3ib-john-1.8.0-jumbo-1/bin/netscreen.py'...
wrapping `/nix/store/bh75rbc1i4r53inpryqlp0svjp7vy3ib-john-1.8.0-jumbo-1/bin/openssl2john.py'...
/nix/store/bh75rbc1i4r53inpryqlp0svjp7vy3ib-john-1.8.0-jumbo-1

GrahamcOfBorg · 2018-05-03T16:14:44Z

Failure on aarch64-linux (full log)

Attempted: john

Partial log (click to expand)

 extern size_t strlen (const char *__s)
               ^~~~~~
truecrypt_fmt_plug.c:314:95: error: 'num_iterations' undeclared (first use in this function)
    pbkdf2_sha512((const unsigned char*)key_buffer[i], strlen(key_buffer[i]), psalt->salt, 64, num_iterations, key, sizeof(key), 0);
                                                                                               ^~~~~~~~~~~~~~
make[1]: *** [Makefile:520: truecrypt_fmt_plug.o] Error 1
make[1]: Leaving directory '/build/john-1.8.0-jumbo-1/src'
make: *** [Makefile:185: default] Error 2
builder for '/nix/store/h4w2nw75xh967jsq8pi7x3hhbmla5aml-john-1.8.0-jumbo-1.drv' failed with exit code 2
�[31;1merror:�[0m build of '/nix/store/h4w2nw75xh967jsq8pi7x3hhbmla5aml-john-1.8.0-jumbo-1.drv' failed

xeji · 2018-05-03T16:15:15Z

why did it try aarch64 again?

GrahamcOfBorg · 2018-05-03T16:19:06Z

Success on x86_64-linux (full log)

Attempted: john

Partial log (click to expand)

/nix/store/bh75rbc1i4r53inpryqlp0svjp7vy3ib-john-1.8.0-jumbo-1

GrahamcOfBorg · 2018-05-03T16:19:11Z

No attempt on x86_64-darwin (full log)

The following builds were skipped because they don't evaluate on x86_64-darwin: john

Partial log (click to expand)


a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowUnsupportedSystem = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowUnsupportedSystem = true; }
to ~/.config/nixpkgs/config.nix.

GrahamcOfBorg · 2018-05-03T16:24:59Z

Failure on aarch64-linux (full log)

Attempted: john

Partial log (click to expand)

 extern size_t strlen (const char *__s)
               ^~~~~~
truecrypt_fmt_plug.c:314:95: error: 'num_iterations' undeclared (first use in this function)
    pbkdf2_sha512((const unsigned char*)key_buffer[i], strlen(key_buffer[i]), psalt->salt, 64, num_iterations, key, sizeof(key), 0);
                                                                                               ^~~~~~~~~~~~~~
make[1]: *** [Makefile:520: truecrypt_fmt_plug.o] Error 1
make[1]: Leaving directory '/build/john-1.8.0-jumbo-1/src'
make: *** [Makefile:185: default] Error 2
builder for '/nix/store/h4w2nw75xh967jsq8pi7x3hhbmla5aml-john-1.8.0-jumbo-1.drv' failed with exit code 2
�[31;1merror:�[0m build of '/nix/store/h4w2nw75xh967jsq8pi7x3hhbmla5aml-john-1.8.0-jumbo-1.drv' failed

xeji · 2018-05-05T16:22:14Z

pkgs/tools/security/john/default.nix

@@ -69,6 +69,6 @@ stdenv.mkDerivation rec {
    license = licenses.gpl2;
    homepage = https://github.com/magnumripper/JohnTheRipper/;
    maintainers = with maintainers; [ offline ];
-    platforms = platforms.unix;
+    platforms = filter (p: p != "aarch64-linux") platforms.unix;


Several other packages do this but it doesn't seem to work with the new platform logic, which I don't fully understand yet. The only working solution that I found so far is an old-style whitelist:
platforms = [ "x86_64-linux" "x86_64-darwin"];

Mic92 · 2018-05-05T17:26:19Z

@GrahamcOfBorg build john

GrahamcOfBorg · 2018-05-05T17:26:45Z

No attempt on aarch64-linux (full log)

The following builds were skipped because they don't evaluate on aarch64-linux: john

Partial log (click to expand)


a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowUnsupportedSystem = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowUnsupportedSystem = true; }
to ~/.config/nixpkgs/config.nix.

GrahamcOfBorg · 2018-05-05T17:28:02Z

No attempt on x86_64-darwin (full log)

The following builds were skipped because they don't evaluate on x86_64-darwin: john

Partial log (click to expand)


a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowUnsupportedSystem = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowUnsupportedSystem = true; }
to ~/.config/nixpkgs/config.nix.

GrahamcOfBorg · 2018-05-05T17:32:12Z

Success on x86_64-linux (full log)

Attempted: john

Partial log (click to expand)

wrapping `/nix/store/bh75rbc1i4r53inpryqlp0svjp7vy3ib-john-1.8.0-jumbo-1/bin/openssl2john.py'...
wrapping `/nix/store/bh75rbc1i4r53inpryqlp0svjp7vy3ib-john-1.8.0-jumbo-1/bin/office2john.py'...
wrapping `/nix/store/bh75rbc1i4r53inpryqlp0svjp7vy3ib-john-1.8.0-jumbo-1/bin/blockchain2john.py'...
wrapping `/nix/store/bh75rbc1i4r53inpryqlp0svjp7vy3ib-john-1.8.0-jumbo-1/bin/sxc2john.py'...
wrapping `/nix/store/bh75rbc1i4r53inpryqlp0svjp7vy3ib-john-1.8.0-jumbo-1/bin/lotus2john.py'...
wrapping `/nix/store/bh75rbc1i4r53inpryqlp0svjp7vy3ib-john-1.8.0-jumbo-1/bin/cracf2john.py'...
wrapping `/nix/store/bh75rbc1i4r53inpryqlp0svjp7vy3ib-john-1.8.0-jumbo-1/bin/strip2john.py'...
wrapping `/nix/store/bh75rbc1i4r53inpryqlp0svjp7vy3ib-john-1.8.0-jumbo-1/bin/7z2john.py'...
wrapping `/nix/store/bh75rbc1i4r53inpryqlp0svjp7vy3ib-john-1.8.0-jumbo-1/bin/openbsd_softraid2john.py'...
/nix/store/bh75rbc1i4r53inpryqlp0svjp7vy3ib-john-1.8.0-jumbo-1

GrahamcOfBorg · 2018-05-05T17:40:50Z

No attempt on aarch64-linux (full log)

The following builds were skipped because they don't evaluate on aarch64-linux: john

Partial log (click to expand)


a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowUnsupportedSystem = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowUnsupportedSystem = true; }
to ~/.config/nixpkgs/config.nix.

GrahamcOfBorg · 2018-05-05T17:41:52Z

No attempt on x86_64-darwin (full log)

The following builds were skipped because they don't evaluate on x86_64-darwin: john

Partial log (click to expand)


a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowUnsupportedSystem = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowUnsupportedSystem = true; }
to ~/.config/nixpkgs/config.nix.

GrahamcOfBorg · 2018-05-05T17:42:40Z

Success on x86_64-linux (full log)

Attempted: john

Partial log (click to expand)

wrapping `/nix/store/bh75rbc1i4r53inpryqlp0svjp7vy3ib-john-1.8.0-jumbo-1/bin/mcafee_epo2john.py'...
wrapping `/nix/store/bh75rbc1i4r53inpryqlp0svjp7vy3ib-john-1.8.0-jumbo-1/bin/1password2john.py'...
wrapping `/nix/store/bh75rbc1i4r53inpryqlp0svjp7vy3ib-john-1.8.0-jumbo-1/bin/efs2john.py'...
wrapping `/nix/store/bh75rbc1i4r53inpryqlp0svjp7vy3ib-john-1.8.0-jumbo-1/bin/cracf2john.py'...
wrapping `/nix/store/bh75rbc1i4r53inpryqlp0svjp7vy3ib-john-1.8.0-jumbo-1/bin/strip2john.py'...
wrapping `/nix/store/bh75rbc1i4r53inpryqlp0svjp7vy3ib-john-1.8.0-jumbo-1/bin/ecryptfs2john.py'...
wrapping `/nix/store/bh75rbc1i4r53inpryqlp0svjp7vy3ib-john-1.8.0-jumbo-1/bin/odf2john.py'...
wrapping `/nix/store/bh75rbc1i4r53inpryqlp0svjp7vy3ib-john-1.8.0-jumbo-1/bin/openbsd_softraid2john.py'...
wrapping `/nix/store/bh75rbc1i4r53inpryqlp0svjp7vy3ib-john-1.8.0-jumbo-1/bin/htdigest2john.py'...
/nix/store/bh75rbc1i4r53inpryqlp0svjp7vy3ib-john-1.8.0-jumbo-1

john: build with recent gcc

07ee2b9

GrahamcOfBorg added 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 labels May 3, 2018

Mic92 force-pushed the john branch from 8d46544 to 3b1c9a4 Compare May 3, 2018 16:08

xeji reviewed May 5, 2018

View reviewed changes

john: disable aarch64

7ac652d

Mic92 force-pushed the john branch from 3b1c9a4 to 7ac652d Compare May 5, 2018 17:26

GrahamcOfBorg added the 8.has: clean-up label May 5, 2018

xeji merged commit 38ae210 into NixOS:master May 5, 2018

Mic92 deleted the john branch May 7, 2018 08:56

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

john: build with recent gcc #39929

john: build with recent gcc #39929

Mic92 commented May 3, 2018 •

edited

Mic92 commented May 3, 2018

GrahamcOfBorg commented May 3, 2018

GrahamcOfBorg commented May 3, 2018

GrahamcOfBorg commented May 3, 2018

GrahamcOfBorg commented May 3, 2018

GrahamcOfBorg commented May 3, 2018

GrahamcOfBorg commented May 3, 2018

xeji commented May 3, 2018

Mic92 commented May 3, 2018

GrahamcOfBorg commented May 3, 2018

GrahamcOfBorg commented May 3, 2018

GrahamcOfBorg commented May 3, 2018

xeji commented May 3, 2018

GrahamcOfBorg commented May 3, 2018

GrahamcOfBorg commented May 3, 2018

GrahamcOfBorg commented May 3, 2018

xeji May 5, 2018

Mic92 commented May 5, 2018

GrahamcOfBorg commented May 5, 2018

GrahamcOfBorg commented May 5, 2018

GrahamcOfBorg commented May 5, 2018

GrahamcOfBorg commented May 5, 2018

GrahamcOfBorg commented May 5, 2018

GrahamcOfBorg commented May 5, 2018

john: build with recent gcc #39929

john: build with recent gcc #39929

Conversation

Mic92 commented May 3, 2018 • edited

Motivation for this change

Things done

Mic92 commented May 3, 2018

GrahamcOfBorg commented May 3, 2018

GrahamcOfBorg commented May 3, 2018

GrahamcOfBorg commented May 3, 2018

GrahamcOfBorg commented May 3, 2018

GrahamcOfBorg commented May 3, 2018

GrahamcOfBorg commented May 3, 2018

xeji commented May 3, 2018

Mic92 commented May 3, 2018

GrahamcOfBorg commented May 3, 2018

GrahamcOfBorg commented May 3, 2018

GrahamcOfBorg commented May 3, 2018

xeji commented May 3, 2018

GrahamcOfBorg commented May 3, 2018

GrahamcOfBorg commented May 3, 2018

GrahamcOfBorg commented May 3, 2018

xeji May 5, 2018

Choose a reason for hiding this comment

Mic92 commented May 5, 2018

GrahamcOfBorg commented May 5, 2018

GrahamcOfBorg commented May 5, 2018

GrahamcOfBorg commented May 5, 2018

GrahamcOfBorg commented May 5, 2018

GrahamcOfBorg commented May 5, 2018

GrahamcOfBorg commented May 5, 2018

Mic92 commented May 3, 2018 •

edited