Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cointop: init at 2018-05-03 #39920

Merged
merged 1 commit into from May 3, 2018
Merged

cointop: init at 2018-05-03 #39920

merged 1 commit into from May 3, 2018

Conversation

matthiasbeyer
Copy link
Contributor

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

Not added myself as maintainer because of reasons explained in #38504

xeji
xeji reviewed May 3, 2018
View reviewed changes
pkgs/applications/misc/cointop/default.nix Outdated
@@ -0,0 +1,30 @@
{ lib, stdenv, buildGoPackage, fetchgit, fetchhg, fetchbzr, fetchsvn }:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

are fetchhg, fetchbzr, fetchsvn really needed here?

pkgs/applications/misc/cointop/default.nix Outdated
The interface is inspired by htop and shortcut keys are inspired by vim.
'';
homepage = https://cointop.sh;
platforms = lib.meta.platforms.linux; # cannot test others
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

platforms = stdenv.lib.platforms.linux; to fix eval

@matthiasbeyer
Copy link
Contributor Author

@xeji done.

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: cointop

Partial log (click to expand)

strip is /nix/store/j75dgadrff2d1fyc4fczmcgqkid2imdx-binutils-2.30/bin/strip
patching script interpreter paths in /nix/store/3p9ghhsglcidz85hdzs89aqjvgjgnfrj-cointop-unstable-2018-05-03
/nix/store/3p9ghhsglcidz85hdzs89aqjvgjgnfrj-cointop-unstable-2018-05-03/share/go/src/github.com/miguelmota/cointop/vendor/golang.org/x/sys/unix/mkall.sh: interpreter directive changed from "/usr/bin/env bash" to "/nix/store/xn5gv3lpfy91yvfy9b0i7klfcxh9xskz-bash-4.4-p19/bin/bash"
/nix/store/3p9ghhsglcidz85hdzs89aqjvgjgnfrj-cointop-unstable-2018-05-03/share/go/src/github.com/miguelmota/cointop/vendor/golang.org/x/sys/unix/mkerrors.sh: interpreter directive changed from "/usr/bin/env bash" to "/nix/store/xn5gv3lpfy91yvfy9b0i7klfcxh9xskz-bash-4.4-p19/bin/bash"
/nix/store/3p9ghhsglcidz85hdzs89aqjvgjgnfrj-cointop-unstable-2018-05-03/share/go/src/github.com/miguelmota/cointop/vendor/golang.org/x/sys/plan9/mkall.sh: interpreter directive changed from "/usr/bin/env bash" to "/nix/store/xn5gv3lpfy91yvfy9b0i7klfcxh9xskz-bash-4.4-p19/bin/bash"
/nix/store/3p9ghhsglcidz85hdzs89aqjvgjgnfrj-cointop-unstable-2018-05-03/share/go/src/github.com/miguelmota/cointop/vendor/golang.org/x/sys/plan9/mksysnum_plan9.sh: interpreter directive changed from "/bin/sh" to "/nix/store/xn5gv3lpfy91yvfy9b0i7klfcxh9xskz-bash-4.4-p19/bin/sh"
/nix/store/3p9ghhsglcidz85hdzs89aqjvgjgnfrj-cointop-unstable-2018-05-03/share/go/src/github.com/miguelmota/cointop/vendor/golang.org/x/sys/plan9/mkerrors.sh: interpreter directive changed from "/usr/bin/env bash" to "/nix/store/xn5gv3lpfy91yvfy9b0i7klfcxh9xskz-bash-4.4-p19/bin/bash"
/nix/store/3p9ghhsglcidz85hdzs89aqjvgjgnfrj-cointop-unstable-2018-05-03/share/go/src/github.com/miguelmota/cointop/install.sh: interpreter directive changed from "/bin/bash" to "/nix/store/xn5gv3lpfy91yvfy9b0i7klfcxh9xskz-bash-4.4-p19/bin/bash"
checking for references to /build in /nix/store/3p9ghhsglcidz85hdzs89aqjvgjgnfrj-cointop-unstable-2018-05-03...
/nix/store/gc005z90lvs8fd4rssk7r6gqlr2q3c4y-cointop-unstable-2018-05-03-bin

@GrahamcOfBorg
Copy link

No attempt on x86_64-darwin (full log)

The following builds were skipped because they don't evaluate on x86_64-darwin: cointop

Partial log (click to expand)


a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowUnsupportedSystem = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowUnsupportedSystem = true; }
to ~/.config/nixpkgs/config.nix.

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: cointop

Partial log (click to expand)

strip is /nix/store/gp7fylxwn18b7pl2c18ks89hsiaxyfvf-binutils-2.30/bin/strip
patching script interpreter paths in /nix/store/8rd1dbvcnwddz38l9kp30x5qmaj6wjhv-cointop-unstable-2018-05-03
/nix/store/8rd1dbvcnwddz38l9kp30x5qmaj6wjhv-cointop-unstable-2018-05-03/share/go/src/github.com/miguelmota/cointop/install.sh: interpreter directive changed from "/bin/bash" to "/nix/store/a4qslf0yfs44mhnbagarn232sjnckhy0-bash-4.4-p19/bin/bash"
/nix/store/8rd1dbvcnwddz38l9kp30x5qmaj6wjhv-cointop-unstable-2018-05-03/share/go/src/github.com/miguelmota/cointop/vendor/golang.org/x/sys/plan9/mkall.sh: interpreter directive changed from "/usr/bin/env bash" to "/nix/store/a4qslf0yfs44mhnbagarn232sjnckhy0-bash-4.4-p19/bin/bash"
/nix/store/8rd1dbvcnwddz38l9kp30x5qmaj6wjhv-cointop-unstable-2018-05-03/share/go/src/github.com/miguelmota/cointop/vendor/golang.org/x/sys/plan9/mkerrors.sh: interpreter directive changed from "/usr/bin/env bash" to "/nix/store/a4qslf0yfs44mhnbagarn232sjnckhy0-bash-4.4-p19/bin/bash"
/nix/store/8rd1dbvcnwddz38l9kp30x5qmaj6wjhv-cointop-unstable-2018-05-03/share/go/src/github.com/miguelmota/cointop/vendor/golang.org/x/sys/plan9/mksysnum_plan9.sh: interpreter directive changed from "/bin/sh" to "/nix/store/a4qslf0yfs44mhnbagarn232sjnckhy0-bash-4.4-p19/bin/sh"
/nix/store/8rd1dbvcnwddz38l9kp30x5qmaj6wjhv-cointop-unstable-2018-05-03/share/go/src/github.com/miguelmota/cointop/vendor/golang.org/x/sys/unix/mkall.sh: interpreter directive changed from "/usr/bin/env bash" to "/nix/store/a4qslf0yfs44mhnbagarn232sjnckhy0-bash-4.4-p19/bin/bash"
/nix/store/8rd1dbvcnwddz38l9kp30x5qmaj6wjhv-cointop-unstable-2018-05-03/share/go/src/github.com/miguelmota/cointop/vendor/golang.org/x/sys/unix/mkerrors.sh: interpreter directive changed from "/usr/bin/env bash" to "/nix/store/a4qslf0yfs44mhnbagarn232sjnckhy0-bash-4.4-p19/bin/bash"
checking for references to /build in /nix/store/8rd1dbvcnwddz38l9kp30x5qmaj6wjhv-cointop-unstable-2018-05-03...
/nix/store/3q0zh1x9fy1m8mg4rhcy16zixv1fpshj-cointop-unstable-2018-05-03-bin

@xeji xeji merged commit d042b53 into NixOS:master May 3, 2018
@matthiasbeyer matthiasbeyer deleted the add-cointop branch November 9, 2019 16:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xeji xeji xeji left review comments

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@matthiasbeyer @GrahamcOfBorg @xeji