ledger: enable python command #39919
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -19,7 +19,7 @@ stdenv.mkDerivation rec { | |||
|
|
|||
| enableParallelBuilding = true; | |||
|
|
|||
| cmakeFlags = [ "-DCMAKE_INSTALL_LIBDIR=lib" ]; | |||
| cmakeFlags = [ "-DCMAKE_INSTALL_LIBDIR=lib" "-DUSE_PYTHON=true" ]; | |||
There was a problem hiding this comment.
Can we turn this into a package option?
There was a problem hiding this comment.
Sadly, I wouldn't know how.
There was a problem hiding this comment.
You'd add a parameter to the input of the function which is true by default: {... usePython ? true ... }:
then you'd check it in the cmakeFlags like this: (if usePython then "-DUSE_PYTHON=true" else ""); or you'd use (lib.optionalString usePython "-DUSE_PYTHON=true").
There was a problem hiding this comment.
Oh, easy enough. I'll update the PR.
ledger in nixpkgs currently uses python (it’s in buildInputs), but the ledger python command isn’t available until you turn it on via a cmake flag.
pmiddend
force-pushed
the
ledger-use-python
branch
from
d428ea3
to
b62788f
Compare
|
@GrahamcOfBorg build ledger |
|
Success on x86_64-linux (full log) Attempted: ledger Partial log (click to expand)
|
|
Success on aarch64-linux (full log) Attempted: ledger Partial log (click to expand)
|
|
Success on x86_64-darwin (full log) Attempted: ledger Partial log (click to expand)
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
ledger in nixpkgs currently uses python (it’s in
buildInputs), but theledger python command isn’t available until you turn it on via a cmake
flag.
Things done
build-use-sandboxinnix.confon non-NixOS)nix-shell -p nox --run "nox-review wip"./result/bin/)