macOS closure-size reduction #39940
Merged
macOS closure-size reduction #39940
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a huge directory & not referenced anywhere.
adds 2 outputs for libSystem: - out - dev should shrink closure sizes
|
Success on x86_64-linux (full log) Attempted: gettext The following builds were skipped because they don't evaluate on x86_64-linux: darwin.ICU Partial log (click to expand)
|
|
Failure on x86_64-darwin (full log) Attempted: darwin.ICU, gettext Partial log (click to expand)
|
|
Success on aarch64-linux (full log) Attempted: gettext The following builds were skipped because they don't evaluate on aarch64-linux: darwin.ICU Partial log (click to expand)
|
|
Failure on x86_64-darwin (full log) Attempted: darwin.ICU, gettext Partial log (click to expand)
|
|
Failure on x86_64-linux (full log) Attempted: gettext The following builds were skipped because they don't evaluate on x86_64-linux: darwin.ICU Partial log (click to expand)
|
|
Success on aarch64-linux (full log) Attempted: gettext The following builds were skipped because they don't evaluate on aarch64-linux: darwin.ICU Partial log (click to expand)
|
LnL7
approved these changes
May 3, 2018
| @@ -3,10 +3,13 @@ | |||
| removefile, libresolv, Libnotify, libplatform, libpthread, mDNSResponder, launchd, libutil, version }: | |||
|
|
|||
| appleDerivation rec { | |||
| phases = [ "unpackPhase" "installPhase" ]; | |||
There was a problem hiding this comment.
Maybe we should get rid of these in the other apple stuff, it can be pretty confusing when stuff like multiple outputs don't work if you don't think of this immediately.
There was a problem hiding this comment.
Yes! I think they can all be either removed or replaced with dontBuild = true & dontConfigure = true. I'm never sure whether they're actually needed though.
There was a problem hiding this comment.
Yeah, this was all clueless @copumpkin right at the beginning of his Nix career not knowing what he's doing. And yes, he occasionally speaks of himself in the third person.
There was a problem hiding this comment.
That's good to know! Occasionally it's necessary, for instance when a Makefile exists, but I'll just remove all of them & see what breaks.
|
Success on aarch64-linux (full log) Attempted: gettext, stdenv The following builds were skipped because they don't evaluate on aarch64-linux: darwin.ICU Partial log (click to expand)
|
|
Success on x86_64-linux (full log) Attempted: gettext, stdenv The following builds were skipped because they don't evaluate on x86_64-linux: darwin.ICU Partial log (click to expand)
|
|
Failure on x86_64-darwin (full log) Attempted: darwin.ICU, gettext, stdenv Partial log (click to expand)
|
matthewbauer
force-pushed
the
work
branch
2 times, most recently
from
e963d46
to
5206574
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These are a couple of changes to reduce closure size. Based on the output of
nix-store -qR $(nix-build -A nix) | xargs du -sch | sort -h:should reduce:
(also I wonder if aws-sdk-cpp should be disabled by default? it's huge & not necessary for regular Nix users)
Note - I don't have the time to build this right now. I think they are pretty straightforward changes though & hopefully ofborg will succeed.