ArrayList iterator, unifying API of HashMap and its derivatives #981
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BraedonWooding
commented
May 3, 2018
|
|
||
| pub fn next(it: &Iterator) ?T { | ||
| if (it.count >= it.list.len) return null; | ||
| const val = it.list.at(it.count); |
There was a problem hiding this comment.
@andrewrk Currently this seems like the best way to do it? Though I think I could also just index the .items property since I do check bounds.
phase
reviewed
May 3, 2018
| @@ -174,4 +228,4 @@ test "insert ArrayList test" { | |||
| const items = []const i32 { 1 }; | |||
| try list.insertSlice(0, items[0..0]); | |||
| assert(list.items[0] == 5); | |||
| } | |||
| } | |||
There was a problem hiding this comment.
The newlines were removed from the end of all the files you modified.
There was a problem hiding this comment.
Didn't remember having them be part of a standard, if they are I'll add them back; just my visual studio code having its own mind :).
|
Thanks! Looks good |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR just does a small little unification; adding 'count' function to hashmap, arraylist, bufmap, and bufset (which just returns the inner storage value), this is more intended for as we extend the amount of data structures it is nice to have a set of API functions to follow for example having a 'count' function and so on, this makes it easier for library builders to utilise duck typing and support multiple collections in their libraries 馃槃.
Secondly it adds an iterator to ArrayList, again for the above reason. All iterators also have a reset function attached.
Motivation
Again to bring up my Lazy library, I support you doing queries on slices such as
Lazy.init(slice[0..]).where(odd).select(pow).toArray(buf[0..]), and when I wanted to extend it to supporting ArrayLists and Hashmaps I found a problem, they had conflicting APIs (and ArrayList had no iterator), so overall this fixes that by providing a consistent API.