Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

matrix-synapse: 0.27.4 -> 0.28.1 #39922

Merged
merged 1 commit into from May 3, 2018
Merged

matrix-synapse: 0.27.4 -> 0.28.1 #39922

merged 1 commit into from May 3, 2018

Conversation

florianjacob
Copy link
Contributor

Motivation for this change

0.28.1 is an urgent security update: It contains a mitigation for a major denial of service attack that already has been exploited in the wild. For more details, see https://matrix.org/blog/2018/05/01/security-update-synapse-0-28-1/

In my opinion it would make much sense to backport 0.28.1 to stable. Continuing to run vulnerable 0.27.2 out of stable doesn't make much sense anymore, I see no breaking changes from 0.27.2 to 0.28.1, and at least I don't have the time and internal synapse knowledge to backport the temporary workaround to 0.27.2.

For general changelog, see
https://github.com/matrix-org/synapse/blob/master/CHANGES.rst

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@florianjacob
Copy link
Contributor Author

Maintainers: @Ralith @roblabla

@florianjacob
Copy link
Contributor Author

@GrahamcOfBorg test matrix-synapse

@florianjacob
Copy link
Contributor Author

(note that I still could not solve my problems with running the test cases, even on other machines…)

@xeji
Copy link
Contributor

xeji commented May 3, 2018

@GrahamcOfBorg build matrix-synapse

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: matrix-synapse

Partial log (click to expand)

strip is /nix/store/j75dgadrff2d1fyc4fczmcgqkid2imdx-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/10pc0mca7j7iffwvd4yqjn6p4bsr2kwr-matrix-synapse-0.28.1/lib  /nix/store/10pc0mca7j7iffwvd4yqjn6p4bsr2kwr-matrix-synapse-0.28.1/bin
patching script interpreter paths in /nix/store/10pc0mca7j7iffwvd4yqjn6p4bsr2kwr-matrix-synapse-0.28.1
checking for references to /build in /nix/store/10pc0mca7j7iffwvd4yqjn6p4bsr2kwr-matrix-synapse-0.28.1...
wrapping `/nix/store/10pc0mca7j7iffwvd4yqjn6p4bsr2kwr-matrix-synapse-0.28.1/bin/synctl'...
wrapping `/nix/store/10pc0mca7j7iffwvd4yqjn6p4bsr2kwr-matrix-synapse-0.28.1/bin/synapse_port_db'...
wrapping `/nix/store/10pc0mca7j7iffwvd4yqjn6p4bsr2kwr-matrix-synapse-0.28.1/bin/move_remote_media_to_new_store.py'...
wrapping `/nix/store/10pc0mca7j7iffwvd4yqjn6p4bsr2kwr-matrix-synapse-0.28.1/bin/homeserver'...
wrapping `/nix/store/10pc0mca7j7iffwvd4yqjn6p4bsr2kwr-matrix-synapse-0.28.1/bin/register_new_matrix_user'...
wrapping `/nix/store/10pc0mca7j7iffwvd4yqjn6p4bsr2kwr-matrix-synapse-0.28.1/bin/hash_password'...

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: matrix-synapse

Partial log (click to expand)

stripping (with command strip and flags -S) in /nix/store/w15hqrvljmwlz2zh5wwg5ra7gnqmmsvv-matrix-synapse-0.28.1/lib  /nix/store/w15hqrvljmwlz2zh5wwg5ra7gnqmmsvv-matrix-synapse-0.28.1/bin
patching script interpreter paths in /nix/store/w15hqrvljmwlz2zh5wwg5ra7gnqmmsvv-matrix-synapse-0.28.1
checking for references to /build in /nix/store/w15hqrvljmwlz2zh5wwg5ra7gnqmmsvv-matrix-synapse-0.28.1...
wrapping `/nix/store/w15hqrvljmwlz2zh5wwg5ra7gnqmmsvv-matrix-synapse-0.28.1/bin/hash_password'...
wrapping `/nix/store/w15hqrvljmwlz2zh5wwg5ra7gnqmmsvv-matrix-synapse-0.28.1/bin/homeserver'...
wrapping `/nix/store/w15hqrvljmwlz2zh5wwg5ra7gnqmmsvv-matrix-synapse-0.28.1/bin/move_remote_media_to_new_store.py'...
wrapping `/nix/store/w15hqrvljmwlz2zh5wwg5ra7gnqmmsvv-matrix-synapse-0.28.1/bin/register_new_matrix_user'...
wrapping `/nix/store/w15hqrvljmwlz2zh5wwg5ra7gnqmmsvv-matrix-synapse-0.28.1/bin/synapse_port_db'...
wrapping `/nix/store/w15hqrvljmwlz2zh5wwg5ra7gnqmmsvv-matrix-synapse-0.28.1/bin/synctl'...
/nix/store/w15hqrvljmwlz2zh5wwg5ra7gnqmmsvv-matrix-synapse-0.28.1

@xeji
Copy link
Contributor

xeji commented May 3, 2018 •
edited

(note that I still could not solve my problems with running the test cases, even on other machines…)

I just ran the test nixos/tests/matrix-synapse.nix successfully with 0.28.1

xeji
xeji approved these changes May 3, 2018
View reviewed changes
Copy link
Contributor

@xeji xeji left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's ship this asap. I'll backport to stable.

@xeji xeji merged commit 0f62284 into NixOS:master May 3, 2018
xeji pushed a commit to xeji/nixpkgs that referenced this pull request May 3, 2018
@florianjacob @xeji
matrix-synapse: 0.26.1 -> 0.28.1
202c9e6 
Security update, backport of NixOS#39922.
@xeji xeji mentioned this pull request May 3, 2018
Merged
8 tasks
@florianjacob florianjacob deleted the matrix-synapse branch May 3, 2018 22:35
@florianjacob
Copy link
Contributor Author

@xeji Thanks for the quick response! 🙂

@dotlambda
Copy link
Member

@florianjacob Next time please remember to add pythonPackages. to appropriate commit messages.

@florianjacob
Copy link
Contributor Author

@dotlambda thanks, did not know those prefixes were a thing. Will do!

@florianjacob florianjacob mentioned this pull request May 24, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xeji xeji xeji approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@florianjacob @xeji @GrahamcOfBorg @dotlambda