Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[issues/161] Comment function not allowed Java (9,10) > 8 #162

Closed

Conversation

lberoiza
Copy link

@lberoiza lberoiza commented May 3, 2018

Possible Solution to Issue #161

@kares
Copy link
Member

kares commented May 3, 2018

sorry, but this isn't a solution really - Java only prints you with the first warning.
after this you might likely be getting more + as CI suggest not setting the ctor accessible breaks stuff!

@kares kares added the invalid label May 3, 2018
@lberoiza
Copy link
Author

lberoiza commented May 3, 2018

Hi,

Do you have a suggestion, how we can solve this issue, I don't really understand what you mean.
Regards
Luis

@mkristian
Copy link
Member

@lberoiza not setting constructor.setAccessible(true); breaks functionality (see travis-ci ). so unless we find a way to retain functionality and remove the warning we probably stick with the warning.

@kares
Copy link
Member

kares commented May 16, 2018

hmm so this is going in a way of silencing the JDK internal logger reflectively :)
very much appreciate all the effort ... but not sure we would want code such as these around.
it doesn't really solve the issue + we would probably need a fork treating unsafe as JRuby does etc.
long term solution would be to rewrite most of these to use light-weight BC APIs and not rely on JCE.

@kares
Copy link
Member

kares commented Jun 12, 2020

we've attempted to reduce the reflection performed by security helper (for 0.10.5), if this turns out problematic we should attempt some silencing but generally we do not want to have "ugly" module workarounds. thanks for your code thought, very interesting that people actually use these hacks.

@kares kares closed this Jun 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants