Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

switch-to-configuration: use Net::DBus to retrieve the list of units #39938

Merged
merged 1 commit into from May 5, 2018
Merged

switch-to-configuration: use Net::DBus to retrieve the list of units #39938

merged 1 commit into from May 5, 2018

Conversation

edef1c
Copy link
Member

@edef1c edef1c commented May 3, 2018 •
edited

#28206, take two.

Motivation for this change

This resolves the FIXME, and opens up the possibility of using more of
the systemd DBus interface to make things more robust.

Things done

@edef1c
switch-to-configuration: use Net::DBus to retrieve the list of units
54a13b0 
This resolves the FIXME, and opens up the possibility of using more of
the systemd DBus interface to make things more robust.
@edef1c
Copy link
Member Author

edef1c commented May 5, 2018

cc @matthewbauer

@GrahamcOfBorg test switch-test

@GrahamcOfBorg
Copy link

No attempt on aarch64-linux (full log)

The following builds were skipped because they don't evaluate on aarch64-linux: tests.switch-test

Partial log (click to expand)

Cannot nix-instantiate `tests.switch-test' because:
�[31;1merror:�[0m attribute 'switch-test' in selection path 'tests.switch-test' not found

@GrahamcOfBorg
Copy link

No attempt on x86_64-linux (full log)

The following builds were skipped because they don't evaluate on x86_64-linux: tests.switch-test

Partial log (click to expand)

Cannot nix-instantiate `tests.switch-test' because:
error: attribute 'switch-test' in selection path 'tests.switch-test' not found

@edef1c
Copy link
Member Author

edef1c commented May 5, 2018

@GrahamcOfBorg test switchTest

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: tests.switchTest

Partial log (click to expand)

syncing
machine: running command: sync
machine# [   15.626505] systemd[1]: Started Extra networking commands..
machine: exit status 0
test script finished in 17.91s
cleaning up
killing machine (pid 593)
vde_switch: EOF on stdin, cleaning up and exiting
vde_switch: Could not remove ctl dir '/build/vde1.ctl': Directory not empty
/nix/store/9phr85c7hlwni8fxz5ywf8vxgjmm82z0-vm-test-run-switch-test

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: tests.switchTest

Partial log (click to expand)

machine: running command: sync
machine# [   30.963021] systemd[1]: Starting Extra networking commands....
machine# [   30.994879] systemd[1]: Started Extra networking commands..
machine: exit status 0
test script finished in 31.95s
cleaning up
killing machine (pid 627)
vde_switch: EOF on stdin, cleaning up and exiting
vde_switch: Could not remove ctl dir '/build/vde1.ctl': Directory not empty
/nix/store/pkwiyqf76ylw1667b3vyjq3l4dhnz6im-vm-test-run-switch-test

@matthewbauer matthewbauer merged commit bcf8e74 into NixOS:master May 5, 2018
@edef1c edef1c deleted the net-dbus-list-units branch May 6, 2018 11:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
6.topic: nixos 8.has: module (update) 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@edef1c @GrahamcOfBorg @matthewbauer