-
-
Notifications
You must be signed in to change notification settings - Fork 925
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Thread::Backtrace::Location#base_label for blocks differs from MRI #5162
Comments
A test case would be great! |
Oh I submitted too soon. Are you planning to try to fix these issues, or shall we? If it's up to us, it's unlikely to happen before the 9.2 release (next Mondayish). Even if you do it, it's probably going to be a 9.2.1 thing. |
Thanks for the answer, I'll submit a PR with a test case asap then. As for the fix itself I wasn't planning on taking a stab as I don't think I'll have enough time to pick it up soon-ish. |
Ok thanks. I'll leave these marked for 9.2.1 then. May not be too difficult to fix if we can sort out a better way to do the "block in" thing. |
…s from MRI. This fix is not quite what I would have liked but I think the other issue we will need to consider at some point is that this data is not m17n safe. So when we decide to fix that we will need to mangle differently and probably will be able to clean up this a bit.
Hello again!
I'm using
Thread#backtrace_locations
and noticed several differences between MRI and JRuby.I'll report them separately because they may have different fixes, but feel free to mark any as duplicate if it makes sense to do so.
Environment
jruby 9.1.17.0 (2.3.3) 2018-04-20 d8b1ff9 Java HotSpot(TM) 64-Bit Server VM 25.171-b11 on 1.8.0_171-b11 +jit [linux-x86_64]
Linux u186024434db159d25c92 4.13.0-39-generic #44~16.04.1-Ubuntu SMP Thu Apr 5 16:43:10 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux
Ubuntu 16.04.4 LTS
Expected Behavior
When looking at a
Thread::Backtrace::Location
, MRI provides both#base_label
and#label
.For most methods, these are exactly the same, but for blocks it allows the caller to get the name of the method separate from the "block in" text without resorting to parsing the result.
Testcase:
Output on MRI:
Actual Behavior
JRuby does not make such a distinction, and so
base_label
effectively becomes an alias oflabel
:If it would be helpful I can also submit a testcase to RubySpec.
The text was updated successfully, but these errors were encountered: