Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gnused: Remove crossAttrs #40295

Merged
merged 1 commit into from May 10, 2018
Merged

gnused: Remove crossAttrs #40295

merged 1 commit into from May 10, 2018

Conversation

Ericson2314
Copy link
Member

@Ericson2314 Ericson2314 commented May 10, 2018 •
edited

Motivation for this change

Use a cleaner help2man trick from coreutils.

Progress towards #33302.

Things done

Tested on aarch64-linux.

  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@Ericson2314
gnused: Remove crossAttrs
8db05ad 
Use a cleaner help2man trick from coreutils
@GrahamcOfBorg
Copy link

Success on x86_64-darwin (full log)

Attempted: gnused

Partial log (click to expand)

/nix/store/llk6iyb3ppvyaflbkg5rbv960wlsxpkc-gnused-4.4

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: gnused

Partial log (click to expand)

/nix/store/p844gl2lb267aii2jdv5bqx4ph68l25m-gnused-4.4

@Ericson2314 Ericson2314 merged commit 4ed7038 into NixOS:master May 10, 2018
@Ericson2314 Ericson2314 deleted the fewer-crossAttrs branch May 10, 2018 18:46
@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: gnused

Partial log (click to expand)

/nix/store/d0rskrmqn7fjsbc12365qv3m4g1y8vmh-gnused-4.4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Ericson2314 @GrahamcOfBorg