Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup of HandBrake related patches #40280

Merged
merged 5 commits into from May 15, 2018

Conversation

Anton-Latukha
Copy link
Contributor

@Anton-Latukha Anton-Latukha commented May 10, 2018

Motivation for this change

HandBrake upstream has it own ways. And created a set of own patches to many libraries because of different reasons.

Knowing that HandBrake is a project that needs special packaging treatment I became a maintainer of HandBrake package.

This PR is continuation of process of normalization of a package. This changes derived from #39512 (comment)).

More work and discussions on this HandBrake normalization in previous PRs: #38809, #38811, #39117, #39512.

I made a check of our upstream for currently present HB patches in it. And I checked every patch in HandBrake upstream. And checked if patches implemented in our upstream are still relevant to HandBrake upstream. And today this patches are no longer used in HandBrake upstream.

All patches I found can and should be removed, as they are no longer needed.

As patches had altered dependency packages directly, this should solve many side effects.
And would trigger a big rebuild to remove those side effects.

Things done
  • Tested using sandboxing
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

Patches no longer used in HandBrake upstream
Patches no longer used in HandBrake upstream
Patches no longer used in HandBrake upstream
Patch no longer used by HandBrake upstream
@Anton-Latukha Anton-Latukha changed the title Handbrake patch cleanup HandBrake patch cleanup May 10, 2018
@Anton-Latukha Anton-Latukha changed the title HandBrake patch cleanup Cleanup of HandBrake patches May 10, 2018
@Anton-Latukha Anton-Latukha changed the title Cleanup of HandBrake patches Cleanup of patches by HandBrake May 10, 2018
@Anton-Latukha Anton-Latukha changed the title Cleanup of patches by HandBrake Cleanup of HandBrake related patches May 10, 2018
@matthewbauer matthewbauer merged commit 5288fbd into NixOS:master May 15, 2018
@Anton-Latukha Anton-Latukha deleted the handbrake-patch-cleanup branch May 30, 2018 08:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants