Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove SemanticVersion #6038

Closed

Conversation

sdogruyol
Copy link
Member

I think that we should remove SemanticVersion from Crystal std and move it into a shard. This PR removes it.

@RX14
Copy link
Contributor

RX14 commented Apr 30, 2018

Can you explain your reasoning in more depth?

@sdogruyol
Copy link
Member Author

sdogruyol commented May 1, 2018

Even though Crystal follows the SemVer spec, it's not directly tied with each other to be in std. Also SemanticVersion probably has the least practical real world usage amongst stuff which were previously discussed to be removed from std like Markdown.

@straight-shoota
Copy link
Member

I think it's still useful as a macro feature.

Despite the name, the implementation isn't even specific to SemVer, but can even be used with different versioning schemes. So maybe it should be renamed?

But I don't see a reason to remove it, especially considering the implementation is pretty straightforward.

@asterite
Copy link
Member

asterite commented May 1, 2018

I also don't see a need to remove it, plus the macro to compare versions is very useful and without SemanticVersion it wouldn't be possible.

@sdogruyol sdogruyol closed this May 3, 2018
@sdogruyol
Copy link
Member Author

On a second thought, it does no harm to keep it 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants