Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bat: init at 0.2.0 #39748

Merged
merged 1 commit into from May 1, 2018
Merged

bat: init at 0.2.0 #39748

merged 1 commit into from May 1, 2018

Conversation

matthiasbeyer
Copy link
Contributor

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: bat

Partial log (click to expand)

cp: -r not specified; omitting directory 'target/release/examples'
cp: -r not specified; omitting directory 'target/release/incremental'
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/1qwsd6f75d9187isly5xxliq3pr64qg2-bat-0.2.0
shrinking /nix/store/1qwsd6f75d9187isly5xxliq3pr64qg2-bat-0.2.0/bin/bat
strip is /nix/store/j75dgadrff2d1fyc4fczmcgqkid2imdx-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/1qwsd6f75d9187isly5xxliq3pr64qg2-bat-0.2.0/bin
patching script interpreter paths in /nix/store/1qwsd6f75d9187isly5xxliq3pr64qg2-bat-0.2.0
checking for references to /build in /nix/store/1qwsd6f75d9187isly5xxliq3pr64qg2-bat-0.2.0...
/nix/store/1qwsd6f75d9187isly5xxliq3pr64qg2-bat-0.2.0

@GrahamcOfBorg
Copy link

Failure on x86_64-darwin (full log)

Attempted: bat

Partial log (click to expand)

          clang-5.0: error: linker command failed with exit code 1 (use -v to see invocation)


error: aborting due to previous error

error: Could not compile `bat`.

To learn more, run the command again with --verbose.
builder for '/nix/store/bq2p54ybkny990rfc0fv7y1r6i4x23vh-bat-0.2.0.drv' failed with exit code 101
error: build of '/nix/store/bq2p54ybkny990rfc0fv7y1r6i4x23vh-bat-0.2.0.drv' failed

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: bat

Partial log (click to expand)

cp: -r not specified; omitting directory 'target/release/native'
cp: -r not specified; omitting directory 'target/release/deps'
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/v0zaqxf0j2kjd7liwkahkbplawifwns4-bat-0.2.0
shrinking /nix/store/v0zaqxf0j2kjd7liwkahkbplawifwns4-bat-0.2.0/bin/bat
strip is /nix/store/gp7fylxwn18b7pl2c18ks89hsiaxyfvf-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/v0zaqxf0j2kjd7liwkahkbplawifwns4-bat-0.2.0/bin
patching script interpreter paths in /nix/store/v0zaqxf0j2kjd7liwkahkbplawifwns4-bat-0.2.0
checking for references to /build in /nix/store/v0zaqxf0j2kjd7liwkahkbplawifwns4-bat-0.2.0...
/nix/store/v0zaqxf0j2kjd7liwkahkbplawifwns4-bat-0.2.0

xeji
xeji reviewed May 1, 2018
View reviewed changes
pkgs/tools/misc/bat/default.nix
description = "A cat(1) clone with syntax highlighting and Git integration";
homepage = https://github.com/sharkdp/bat;
license = licenses.mit;
maintainers = [];
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would you like to be a maintainer of this package?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, for reasons explained in #38504

pkgs/tools/misc/bat/default.nix Outdated
homepage = https://github.com/sharkdp/bat;
license = licenses.mit;
maintainers = [];
platforms = platforms.unix;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please fix the build for Darwin or exclude it here.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

About to do this.

@xeji
Copy link
Contributor

xeji commented May 1, 2018 

installing
cp: -r not specified; omitting directory 'target/release'
cp: -r not specified; omitting directory 'target/release/deps'
cp: -r not specified; omitting directory 'target/release/.fingerprint'
cp: -r not specified; omitting directory 'target/release/native'
cp: -r not specified; omitting directory 'target/release/build'
cp: -r not specified; omitting directory 'target/release/examples'
cp: -r not specified; omitting directory 'target/release/incremental'

Is it safe to ignore these errors?

@matthiasbeyer
Copy link
Contributor Author

I ran it successfully. I saw these errors, too. So I guess they can be ignored.

@GrahamcOfBorg
Copy link

No attempt on x86_64-darwin (full log)

The following builds were skipped because they don't evaluate on x86_64-darwin: bat

Partial log (click to expand)


a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowUnsupportedSystem = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowUnsupportedSystem = true; }
to ~/.config/nixpkgs/config.nix.

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: bat

Partial log (click to expand)

/nix/store/1qwsd6f75d9187isly5xxliq3pr64qg2-bat-0.2.0

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: bat

Partial log (click to expand)

cp: -r not specified; omitting directory 'target/release/native'
cp: -r not specified; omitting directory 'target/release/deps'
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/v0zaqxf0j2kjd7liwkahkbplawifwns4-bat-0.2.0
shrinking /nix/store/v0zaqxf0j2kjd7liwkahkbplawifwns4-bat-0.2.0/bin/bat
strip is /nix/store/gp7fylxwn18b7pl2c18ks89hsiaxyfvf-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/v0zaqxf0j2kjd7liwkahkbplawifwns4-bat-0.2.0/bin
patching script interpreter paths in /nix/store/v0zaqxf0j2kjd7liwkahkbplawifwns4-bat-0.2.0
checking for references to /build in /nix/store/v0zaqxf0j2kjd7liwkahkbplawifwns4-bat-0.2.0...
/nix/store/v0zaqxf0j2kjd7liwkahkbplawifwns4-bat-0.2.0

@xeji xeji merged commit ec95624 into NixOS:master May 1, 2018
@matthiasbeyer matthiasbeyer deleted the add-bat branch May 2, 2018 12:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xeji xeji xeji left review comments

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@matthiasbeyer @GrahamcOfBorg @xeji