Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nixos/dnsdist: init #39767

Closed
wants to merge 1 commit into from
Closed

nixos/dnsdist: init #39767

wants to merge 1 commit into from

Conversation

dasJ
Copy link
Member

@dasJ dasJ commented Apr 30, 2018

Motivation for this change

There is no module for dnsdist

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@peterhoeg
Copy link
Member

Can you try running this with serviceConfig.DynamicUser = true;? With the capabilities you shouldn't have to run as root. If you set that, you can also get rid of a few of the other bits as they are implied by DynamicUser == true (PrivateTmp, ProtectSystem, etc).

@dasJ
Copy link
Member Author

dasJ commented Jun 9, 2018

@peterhoeg Thanks for the suggestion, but it seems like dnsdist is not starting anymore with this option.

dnsdist[24952]: Configuration '/nix/store/wv3jxr8w6b8g7g6aknncrddjamid2s68-dnsdist.conf' OK!
dnsdist[24952]: Configuration '/nix/store/wv3jxr8w6b8g7g6aknncrddjamid2s68-dnsdist.conf' OK!
dnsdist[24953]: Added downstream server 192.168.1.2:53
dnsdist[24953]: Fatal error: binding socket to 127.0.0.1:53: Permission denied

With the module here, everything works.

@peterhoeg
Copy link
Member

You need to change CapabilityBoundingSet to AmbientCapabilities and it should work.

@xeji
Copy link
Contributor

xeji commented Jun 13, 2018

Closing in favor of #37289 which was just merged.

@xeji xeji closed this Jun 13, 2018
@dasJ dasJ deleted the dnsdist-module branch June 13, 2018 13:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
6.topic: nixos 8.has: module (update) 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@dasJ @peterhoeg @xeji @GrahamcOfBorg