treewide: platforms.gnu -> gnu ++ linux, allow using musl #39773
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
"platforms.gnu" has been linux-only since at least 17.03: $ nix eval -f channel:nixos-17.03 lib.platforms.gnu [ "i686-linux" "x86_64-linux" "armv5tel-linux" "armv6l-linux" "armv7l-linux" "aarch64-linux" "mips64el-linux" ] Unlike platforms.linux, platforms.gnu indicates "must use glibc" which for the most part is not intended. Replacing platforms.gnu with platforms.linux would be the same "today" but let's err on preserving existing behavior and be optimistic about platforms these packages work on.
Include all linux platforms.
GrahamcOfBorg
added
6.topic: emacs
6.topic: GNOME
|
Success on x86_64-darwin (full log) Attempted: mtools Partial log (click to expand)
|
|
Success on x86_64-linux (full log) Attempted: mtools Partial log (click to expand)
|
|
Success on aarch64-linux (full log) Attempted: mtools Partial log (click to expand)
|
matthewbauer
reviewed
May 1, 2018
| @@ -48,6 +48,6 @@ stdenv.mkDerivation rec { | |||
| license = stdenv.lib.licenses.gpl3Plus; | |||
|
|
|||
| maintainers = [ ]; | |||
| platforms = stdenv.lib.platforms.gnu; | |||
| platforms = stdenv.lib.platforms.gnu ++ stdenv.lib.platforms.linux; | |||
There was a problem hiding this comment.
This one should be stdenv.lib.platforms.unix (it works on Darwin)
There was a problem hiding this comment.
Thanks for reviewing! Okay, I'll address this shortly. Hooray for working on more platforms! 👍
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Many packages have use
platforms.gnuas an "arbitrary choice",others perhaps because at some point this indicated more
than building w/Linux.
Whatever the reason, for most (nearly all) packages
platforms.gnuis overly pessimistic and in particulareffectively means "all Linux triples that don't use musl".
This PR extends these to include all linux platforms,
while keeping
platforms.gnuin case we ever supportnon-Linux gnu platforms again.
No rebuilds should be required.
build-use-sandboxinnix.confon non-NixOS)nix-shell -p nox --run "nox-review wip"./result/bin/)