Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

goxel: don't save imgui.ini to working directory #39801

Merged
merged 1 commit into from May 1, 2018
Merged

goxel: don't save imgui.ini to working directory #39801

merged 1 commit into from May 1, 2018

Conversation

tilpner
Copy link
Member

@tilpner tilpner commented May 1, 2018 •
edited

Motivation for this change

Before, goxel would save a file imgui.ini to the current working directory.

imgui.ini
[Window][Debug##Default]
Pos=60,60
Size=400,400
Collapsed=0

[Window][Goxel]
Pos=0,0
Size=959,353
Collapsed=0

This is to save window configuration, presumably to restore them on next execution.

Is this behaviour worth littering CWD?
An alternative would be to change upstream to honor XDG conventions.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@tilpner tilpner mentioned this pull request May 1, 2018
Merged
@xeji
Copy link
Contributor

xeji commented May 1, 2018

@GrahamcOfBorg build goxel

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: goxel

Partial log (click to expand)

glibPreFixupPhase
post-installation fixup
Wrapping program /nix/store/bvingb57pk21hw096vwlcy5i70mkb368-goxel-0.8.0/bin/goxel
shrinking RPATHs of ELF executables and libraries in /nix/store/bvingb57pk21hw096vwlcy5i70mkb368-goxel-0.8.0
shrinking /nix/store/bvingb57pk21hw096vwlcy5i70mkb368-goxel-0.8.0/bin/.goxel-wrapped
strip is /nix/store/j75dgadrff2d1fyc4fczmcgqkid2imdx-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/bvingb57pk21hw096vwlcy5i70mkb368-goxel-0.8.0/bin
patching script interpreter paths in /nix/store/bvingb57pk21hw096vwlcy5i70mkb368-goxel-0.8.0
checking for references to /build in /nix/store/bvingb57pk21hw096vwlcy5i70mkb368-goxel-0.8.0...
/nix/store/bvingb57pk21hw096vwlcy5i70mkb368-goxel-0.8.0

@xeji
Copy link
Contributor

xeji commented May 1, 2018

Is this behaviour worth littering CWD?
An alternative would be to change upstream to honor XDG conventions.

May be worth filing an upstream issue.

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: goxel

Partial log (click to expand)

glibPreFixupPhase
post-installation fixup
Wrapping program /nix/store/gm1jh2rgbh47y9xba4dignnl2k9phc0b-goxel-0.8.0/bin/goxel
shrinking RPATHs of ELF executables and libraries in /nix/store/gm1jh2rgbh47y9xba4dignnl2k9phc0b-goxel-0.8.0
shrinking /nix/store/gm1jh2rgbh47y9xba4dignnl2k9phc0b-goxel-0.8.0/bin/.goxel-wrapped
strip is /nix/store/gp7fylxwn18b7pl2c18ks89hsiaxyfvf-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/gm1jh2rgbh47y9xba4dignnl2k9phc0b-goxel-0.8.0/bin
patching script interpreter paths in /nix/store/gm1jh2rgbh47y9xba4dignnl2k9phc0b-goxel-0.8.0
checking for references to /build in /nix/store/gm1jh2rgbh47y9xba4dignnl2k9phc0b-goxel-0.8.0...
/nix/store/gm1jh2rgbh47y9xba4dignnl2k9phc0b-goxel-0.8.0

@xeji xeji merged commit 164b580 into NixOS:master May 1, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@tilpner @xeji @GrahamcOfBorg