Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

inetutils: use platforms.unix per feedback that works w/Darwin too. #39782

Closed
wants to merge 1 commit into from
Closed

inetutils: use platforms.unix per feedback that works w/Darwin too. #39782

wants to merge 1 commit into from

Conversation

dtzWill
Copy link
Member

@dtzWill dtzWill commented May 1, 2018

#39773 (comment)

  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: inetutils

Partial log (click to expand)

/nix/store/63qdryfhbm0aa93xbxdz8vj05qvfp9bw-inetutils-1.9.4

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: inetutils

Partial log (click to expand)

/nix/store/8ar7rjhirsclyf10qx3syzw6yfk6vp57-inetutils-1.9.4

@GrahamcOfBorg
Copy link

Failure on x86_64-darwin (full log)

Attempted: inetutils

Partial log (click to expand)

void    logwtmp(const char *, const char *, const char *) __OSX_AVAILABLE_BUT_DEPRECATED(__MAC_10_0,__MAC_10_5,__IPHONE_2_0,__IPHONE_2_0);
        ^
3 warnings and 9 errors generated.
make[2]: *** [Makefile:1695: rlogind.o] Error 1
make[2]: Leaving directory '/private/tmp/nix-build-inetutils-1.9.4.drv-0/inetutils-1.9.4/src'
make[1]: *** [Makefile:1491: all-recursive] Error 1
make[1]: Leaving directory '/private/tmp/nix-build-inetutils-1.9.4.drv-0/inetutils-1.9.4'
make: *** [Makefile:1428: all] Error 2
builder for '/nix/store/d344gr9kiwnajv99x79wwna01qsim315-inetutils-1.9.4.drv' failed with exit code 2
�[31;1merror:�[0m build of '/nix/store/d344gr9kiwnajv99x79wwna01qsim315-inetutils-1.9.4.drv' failed

@dtzWill
Copy link
Member Author

dtzWill commented May 1, 2018

Err, @matthewbauer -- thoughts?

@matthewbauer
Copy link
Member

Closing in favor of #39790.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
6.topic: darwin Running or building packages on Darwin 8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@dtzWill @GrahamcOfBorg @matthewbauer