Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nodePackages{v6,v8}: update #39804

Merged
merged 3 commits into from May 7, 2018
Merged

nodePackages{v6,v8}: update #39804

merged 3 commits into from May 7, 2018

Conversation

Mic92
Copy link
Member

@Mic92 Mic92 commented May 1, 2018

Motivation for this change

Might contain security updates so this should be done on a regular base.
I am not sure how we can ensure this on stable.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@matthewbauer
Copy link
Member

Looks good! If you have time, it would be great to see if any other node packages are worth including with the update. I've started a label here:

https://github.com/NixOS/nixpkgs/labels/6.topic%3A%20nodejs

but don't have enough knowledge of NodeJS to feel comfortable merging them.

@Mic92
Copy link
Member Author

Mic92 commented May 7, 2018

@GrahamcOfBorg build nodePackages.elm-oracle nodePackages.imapnotify

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: nodePackages.elm-oracle, nodePackages.imapnotify

Partial log (click to expand)

mv@2.1.1 /nix/store/plb17nsznk4vzir4f2kkhzkgbsxyz37l-node-imapnotify-0.4.1/lib/node_modules/imapnotify/node_modules/mv
ncp@2.0.0 /nix/store/plb17nsznk4vzir4f2kkhzkgbsxyz37l-node-imapnotify-0.4.1/lib/node_modules/imapnotify/node_modules/ncp
rimraf@2.4.5 /nix/store/plb17nsznk4vzir4f2kkhzkgbsxyz37l-node-imapnotify-0.4.1/lib/node_modules/imapnotify/node_modules/rimraf
safe-json-stringify@1.1.0 /nix/store/plb17nsznk4vzir4f2kkhzkgbsxyz37l-node-imapnotify-0.4.1/lib/node_modules/imapnotify/node_modules/safe-json-stringify
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/plb17nsznk4vzir4f2kkhzkgbsxyz37l-node-imapnotify-0.4.1
patching script interpreter paths in /nix/store/plb17nsznk4vzir4f2kkhzkgbsxyz37l-node-imapnotify-0.4.1
checking for references to /build in /nix/store/plb17nsznk4vzir4f2kkhzkgbsxyz37l-node-imapnotify-0.4.1...
/nix/store/fz096larvxpjbdn2l0zzl26vd413jz5p-node-elm-oracle-1.1.1
/nix/store/plb17nsznk4vzir4f2kkhzkgbsxyz37l-node-imapnotify-0.4.1

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: nodePackages.elm-oracle, nodePackages.imapnotify

Partial log (click to expand)

mv@2.1.1 /nix/store/ig980smxh9bfis272cbsh034k10dp7yx-node-imapnotify-0.4.1/lib/node_modules/imapnotify/node_modules/mv
ncp@2.0.0 /nix/store/ig980smxh9bfis272cbsh034k10dp7yx-node-imapnotify-0.4.1/lib/node_modules/imapnotify/node_modules/ncp
rimraf@2.4.5 /nix/store/ig980smxh9bfis272cbsh034k10dp7yx-node-imapnotify-0.4.1/lib/node_modules/imapnotify/node_modules/rimraf
safe-json-stringify@1.1.0 /nix/store/ig980smxh9bfis272cbsh034k10dp7yx-node-imapnotify-0.4.1/lib/node_modules/imapnotify/node_modules/safe-json-stringify
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/ig980smxh9bfis272cbsh034k10dp7yx-node-imapnotify-0.4.1
patching script interpreter paths in /nix/store/ig980smxh9bfis272cbsh034k10dp7yx-node-imapnotify-0.4.1
checking for references to /build in /nix/store/ig980smxh9bfis272cbsh034k10dp7yx-node-imapnotify-0.4.1...
/nix/store/7j6iw31g4h0mjjddcaf47xl792hk2i3z-node-elm-oracle-1.1.1
/nix/store/ig980smxh9bfis272cbsh034k10dp7yx-node-imapnotify-0.4.1

@Mic92 Mic92 merged commit ac255f4 into NixOS:master May 7, 2018
@Mic92 Mic92 deleted the node-packages branch May 7, 2018 09:42
@Mic92
Copy link
Member Author

Mic92 commented May 7, 2018

I added the easy ones to this pull request.

@GrahamcOfBorg
Copy link

Success on x86_64-darwin (full log)

Attempted: nodePackages.elm-oracle, nodePackages.imapnotify

Partial log (click to expand)

path-is-absolute@1.0.1 /nix/store/jsay00c2ja69r0dqvjk16x9gc2m5sqxc-node-imapnotify-0.4.1/lib/node_modules/imapnotify/node_modules/path-is-absolute
moment@2.22.1 /nix/store/jsay00c2ja69r0dqvjk16x9gc2m5sqxc-node-imapnotify-0.4.1/lib/node_modules/imapnotify/node_modules/moment
mv@2.1.1 /nix/store/jsay00c2ja69r0dqvjk16x9gc2m5sqxc-node-imapnotify-0.4.1/lib/node_modules/imapnotify/node_modules/mv
ncp@2.0.0 /nix/store/jsay00c2ja69r0dqvjk16x9gc2m5sqxc-node-imapnotify-0.4.1/lib/node_modules/imapnotify/node_modules/ncp
rimraf@2.4.5 /nix/store/jsay00c2ja69r0dqvjk16x9gc2m5sqxc-node-imapnotify-0.4.1/lib/node_modules/imapnotify/node_modules/rimraf
safe-json-stringify@1.1.0 /nix/store/jsay00c2ja69r0dqvjk16x9gc2m5sqxc-node-imapnotify-0.4.1/lib/node_modules/imapnotify/node_modules/safe-json-stringify
post-installation fixup
patching script interpreter paths in /nix/store/jsay00c2ja69r0dqvjk16x9gc2m5sqxc-node-imapnotify-0.4.1
/nix/store/0fp11hg9iv3lra7r23sc05llw8iwd8c7-node-elm-oracle-1.1.1
/nix/store/jsay00c2ja69r0dqvjk16x9gc2m5sqxc-node-imapnotify-0.4.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
6.topic: nodejs 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Mic92 @matthewbauer @GrahamcOfBorg