Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Virtualbox: boot.loader.grub.timeout was renamed to boot.loader.timeout #446

Closed
wants to merge 1 commit into from

Conversation

nightkr
Copy link
Member

@nightkr nightkr commented Jun 4, 2016

No description provided.

@domenkozar
Copy link
Member

This will break 16.03

@nightkr
Copy link
Member Author

nightkr commented Jun 4, 2016

Oh, sorry, didn't think about that.

@domenkozar
Copy link
Member

We can merge once 16.09 is released.

@danbst
Copy link
Contributor

danbst commented Aug 27, 2016

Actually, there are more of this:

nixops/nix/libvirtd-image.nix:      boot.loader.grub.timeout = 0;
nixops/nix/hetzner.nix:    boot.loader.grub.timeout = 1;
nixops/nix/virtualbox-image-nixops.nix:  boot.loader.grub.timeout = 1;
nixops/nix/libvirtd.nix:    boot.loader.grub.timeout = 0;

@domenkozar domenkozar added this to the 1.4.1 milestone Nov 9, 2016
@edolstra
Copy link
Member

edolstra commented Nov 9, 2016

Changing these is problematic because it means we won't be able to deploy older NixOS versions anymore. I guess we need some way to make option definitions conditional on the NixOS version. However, the module system AFAIK doesn't allow that directly. E.g. you can't say

config = mkIf (... version >= 16.09 ...) {
  boot.loader.timeout = 1;
};

because the options under a mkIf still need to exist even if their value is not used.

@nightkr
Copy link
Member Author

nightkr commented Nov 9, 2016

As a compromise, would it be viable/possible to add boot.loader.timeout as an alias option for older branches of Nixpkgs?

That way, you'd still be unable to deploy older builds of those branches, but if they're pegging Nixpkgs to a specific commit then it shouldn't be too big of a deal to peg Nixops as well.

@edolstra
Copy link
Member

edolstra commented Nov 9, 2016

Yeah, that would be fine.

@domenkozar domenkozar mentioned this pull request Nov 22, 2016
3 tasks
@domenkozar
Copy link
Member

This exact occurance was already fixed by @rbvermaa and the code already does the correct thing in 16.03, so I'll close this and fix the remaining occurances.

@domenkozar domenkozar closed this Dec 6, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants