Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

waitSelect improvements #95

Merged
merged 2 commits into from
Jun 28, 2016
Merged

waitSelect improvements #95

merged 2 commits into from
Jun 28, 2016

Conversation

mohamedhafez
Copy link
Contributor

  • makes waitSelect a bit more efficient for nonblocking calls, by pulling that code outside of RubyThread.BlockingTask
  • As reported in Errno::EAGAIN thrown by SSLSocket#connect_nonblock #93, there is a JRuby bug where there may be old selectors returned by selectedKeys(), this fix checks all selected keys just in case our key is in there but just isn't the first.

…ask, and catch more successful selects in case there is more than one selected key due to a JRuby bug
@kares
Copy link
Member

kares commented Jun 4, 2016

looking good, thank you.
right, we do not need the blocking task - would like to wait for feedback for the "leaking" selector pool issue at JRuby's. as I'd like to possibly confirm your thoughts on why its actually happening.

@mohamedhafez
Copy link
Contributor Author

@kares jruby/jruby#3952 to fix the selector pool issue just got merged

@kares kares merged commit 4458259 into jruby:master Jun 28, 2016
@kares
Copy link
Member

kares commented Jun 28, 2016

@mohamedhafez great, thanks again!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants