Improve Crystal version detection #2856
Merged
+45
−22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Note that I'd like to release 0.18.1, not 0.18.0+15. Do your changes work with that in mind? |
|
Yes. Note I just edited the description to clarify how versions on Travis now look like. |
|
I also wouldn't error in the first case. A library might depend on the compiler and it would be tedious if it didn't compile out of the box and one would have to set an ENV var for that. |
|
What about inheriting |
|
Good idea :-) |
jhass
force-pushed
the
sane_version_detection
branch
from
adf408d to
360a7ec
Compare
* Inherit parent compiler version if git is unavailable/failed and no explicit version is given * Handle shallow clones by assuming being compiled by the latest released compiler * Preserve commits since release in version number unless there are none
jhass
force-pushed
the
sane_version_detection
branch
from
360a7ec to
c10b977
Compare
jhass
added a commit
that referenced
this pull request
Jun 16, 2016
Improve Crystal version detection
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
released compiler
The last point means the head version now looks like this:
Crystal 0.18.0+23 [adf408d] (2016-06-16), withCrystal::VERSIONbeing0.18.0+23. This is in accordance with http://semver.org/#spec-item-10Travis does shallow clones, but it will always compile with the latest released compiler, that means with this the first
std_specrun will haveCrystal::VERSIONbe the latest released compiler, so currently0.18.0, the secondstd_specrun will haveCrystal::VERSIONwith the shallow clone case, so currently0.18.0+?.The build in this PR will fail as long as
CRYSTAL_CONFIG_VERSIONis set via Travis web interface. This is why it's always to prefer to set environment variables via.travis.ymlorbin/ci.