Add StringLiteral#> and StringLiteral#< #2858
Merged
+46
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Derp, wrong target branch, should be merged to |
|
What about ">=" and "<="? |
|
Go ahead :P |
|
@jhass no worries, we can add those later. Want to recreate the PR and target release/0.18 ? |
|
Nah, I'll just manually merge it into the right branch once CI passes. |
jhass
force-pushed
the
string_literal_compare
branch
from
4a3b22e to
1779984
Compare
|
Note that it doesn't naturally compare, so |
|
Yes, but I think it's good enough for now, we'll only use between two versions in the compiler. |
jhass
added a commit
that referenced
this pull request
Jun 16, 2016
Add StringLiteral#> and StringLiteral#<
|
I merely outlined that the behavior may not always be correct, especially since it may be used outside of the compiler. Maybe a proper version comparison would be a nice to have in macros? |
|
Sure, would be fine from my side. See #2632 (comment) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Given #2856, then starting with 0.19 (or 0.18.2, depending on whether we want 0.18.x to be compilable with 0.18.0 or 0.17.4 or not) we should be able to do stuff like
{% if Crystal::VERSION > "0.19.0" %}with this, which will then patch things in for 0.19.0+x, 0.19.1 etc.