Skip to content

Commit

Permalink
runtime: disable lwip TCP keepalive.
Browse files Browse the repository at this point in the history 
This sometimes results in an RST sent by lwip after a retransmission,
although it is not clear exactly why. See #456.
whitequark committed Jun 20, 2016
1 parent f5deafb commit 0db6ef0
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion artiq/runtime/liblwip/lwipopts.h
View file
Original file line number Diff line number Diff line change
@@ -105,7 +105,7 @@ a lot of data that needs to be copied, this should be set high. */

/* ---------- TCP options ---------- */
#define LWIP_TCP 1
#define LWIP_TCP_KEEPALIVE 1
#define LWIP_TCP_KEEPALIVE 0
#define TCP_KEEPIDLE_DEFAULT 1250
#define TCP_KEEPINTVL_DEFAULT 1000
#define TCP_KEEPCNT_DEFAULT 3

4 comments on commit 0db6ef0

@sbourdeauducq
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you try a newer lwip?

@whitequark
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No. Should I?

@sbourdeauducq
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes. We need keepalive so this is not a solution.

@whitequark
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK.

Please sign in to comment.