Skip to content

Commit

Permalink
Mark a spec that "generally" works as pending
Browse files Browse the repository at this point in the history
Ary Borenszweig committed Jun 14, 2016
1 parent 28a5235 commit 3259b71
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion spec/std/benchmark_spec.cr
View file
Original file line number Diff line number Diff line change
@@ -9,7 +9,7 @@ typeof(begin
end)

describe Benchmark::IPS::Job do
it "generally works" do
pending "generally works" do
# test several things to avoid running a benchmark over and over again in
# the specs
j = Benchmark::IPS::Job.new(0.001, 0.001, interactive: false)

2 comments on commit 3259b71

@asterite
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@will Could you explain this spec? It sometimes fails on travis, like in here. The name "generally works" suggests it sometimes works and sometimes doesn't, which isn't very good to have on travis. Also check this: http://irclog.whitequark.org/crystal-lang/2016-06-14#1465907024-1465907089;

@will
Copy link
Contributor

@will will commented on 3259b71 Jun 14, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The "generally works" was not intended that it works sometimes and not others, rather that it was more of an integration test instead of a unit test.

I didn't know that timers have 0.01 precision, which makes it a flawed test. All that matters is that one of the two is normalized to 1, not really which one is, so I'll fix it to just test that.

Please sign in to comment.