Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add 64-bit support to PDL::IO::FITS #186

Closed
wants to merge 1 commit into from
Closed

Conversation

drzowie
Copy link
Contributor

@drzowie drzowie commented Jun 7, 2016

Fixes bug #421 (no 64 bit support for wfits/rfits)

@wchristian wchristian closed this Jun 7, 2016
@wchristian wchristian deleted the fits-64bit-fix branch June 7, 2016 05:30
@drzowie
Copy link
Contributor Author

drzowie commented Jun 7, 2016

OK, so I admit to being a bit slow here. Does this mean the pull was accepted? Or that it vanished into hyperspace?

Checking out branch master, I notice that the mods seem to have vanished…

On Jun 6, 2016, at 11:30 PM, Christian Walde (Mithaldu) notifications@github.com wrote:

Closed #186 #186.


You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub #186 (comment), or mute the thread https://github.com/notifications/unsubscribe/ABMzNomYwlfV87CA2B2iIeujajvQE8nxks5qJQIBgaJpZM4IvkfF.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.007%) to 62.699% when pulling 10494df on fits-64bit-fix into e16961c on master.

@zmughal
Copy link
Member

zmughal commented Jun 7, 2016

I see in the IRC log that you pushed the changes for 10494df twice and they got deleted each time.

This is because, right now, the Sourceforge Git repository is considered the authoritative source. When a change appears on GitHub that isn't on Sourceforge, it gets rolled back through @wchristian's synchronisation cron job.

The approach I take is to make my origin remote push to both Sourceforge and GitHub (replace the sf.net username with your own):

git remote set-url --push origin git@github.com:PDLPorters/pdl.git
git remote set-url --add --push origin ssh://zsmughal@git.code.sf.net/p/pdl/code

Now when I do a push, it goes to both places with one command.

@drzowie
Copy link
Contributor Author

drzowie commented Jun 7, 2016

Sweet! Thanks for the pro tip, Zaki.

(Mobile)

On Jun 7, 2016, at 12:39 AM, Zaki Mughal [sivoais] notifications@github.com wrote:

I see in the IRC log that you pushed the changes for 10494df twice and they got deleted each time.

This is because, right now, the Sourceforge Git repository is considered the authoritative source. When a change appears on GitHub that isn't on Sourceforge, it gets rolled back through @wchristian's synchronisation cron job.

The approach I take is to make my origin remote push to both Sourceforge and GitHub (replace the sf.net username with your own):

git remote set-url --push origin git@github.com:PDLPorters/pdl.git
git remote set-url --add --push origin ssh://zsmughal@git.code.sf.net/p/pdl/code
Now when I do a push, it goes to both places with one command.


You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or mute the thread.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants