Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix #2360 #2363

Merged
merged 1 commit into from Jun 4, 2016
Merged

fix #2360 #2363

merged 1 commit into from Jun 4, 2016

Conversation

ralsina
Copy link
Member

@ralsina ralsina commented Jun 4, 2016

If NIKOLA_MONO is set, don't use colors.

@Kwpolska
Copy link
Member

Kwpolska commented Jun 4, 2016

Why not make this a config option instead (say, __colorful__)? Environment variables are a bit ugly in general. We could move things around a bit to facilitate that.

@ralsina
Copy link
Member Author

ralsina commented Jun 4, 2016

because it also should affect things done without config, like init

El sáb., jun. 4, 2016 12:42, Chris Warrick notifications@github.com
escribió:

Why not make this a config option instead (say, colorful)?
Environment variables are a bit ugly in general. We could move things
around a bit to facilitate that.

—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
#2363 (comment),
or mute the thread
https://github.com/notifications/unsubscribe/AAAGK9jWbm63pyePT8-kiJx1qxg0-UdSks5qIZzugaJpZM4IuJ1-
.

@Kwpolska
Copy link
Member

Kwpolska commented Jun 4, 2016

Why not do both?

@ralsina ralsina merged commit 3d5ab23 into master Jun 4, 2016
@ralsina ralsina deleted the mono-output branch June 4, 2016 16:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ralsina @Kwpolska