Add Union type #2736
Merged
Add Union type #2736
+194
−18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Foo(Char | String).bar | ||
| ), | ||
| "can't lookup type in union (Char | String)" | ||
| end |
There was a problem hiding this comment.
So this would now always look up in Union?
There was a problem hiding this comment.
If you do UnionType::T it gives you the T (the union type). Otherwise it searches in the program. Originally it gave an error when not using T, but the problem is that inside a Union method one wants Int32 and other types to be found.
Hmmm... it's a border case which I think doesn't matter, but now that you mention it, I think it can be done in a better way. I'll try to revive that spec. In fact, the new error was "undefined constant T::Bar" or something like that, which is the correct error message after all. Thanks for checking this, @jhass
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After this comment I thought it a bit more and came to the conclusion that even though a method in
Unionwouldn't make sense, a class method makes sense, and this is the key to implement union related stuff.Fixes #2659 . Fixes #2727 . Related to #2714 (doesn't fix it because we are still missing YAML support, but we don't have
parse_rawfor YAML)