Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

amarok: set MY_BASEDIR_VERSION to avoid DEFAULT_MYSQL_HOME /not/a/rea… #16578

Closed
wants to merge 1 commit into from
Closed

amarok: set MY_BASEDIR_VERSION to avoid DEFAULT_MYSQL_HOME /not/a/rea… #16578

wants to merge 1 commit into from

Conversation

jerith666
Copy link
Contributor

Motivation for this change

This fixes #15264.

Things done
  • Tested using sandboxing
    (nix.useSandbox on NixOS,
    or option build-use-sandbox in nix.conf
    on non-NixOS)
  • Built on platform(s)
    • NixOS
    • OS X
    • Linux
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@jerith666 jerith666 mentioned this pull request Jun 29, 2016
Closed
@pwetzel pwetzel mentioned this pull request Jul 1, 2016
Closed
@jerith666
Copy link
Contributor Author

The 1st CI failure here is spurious, due to a full disk. I think the second one is too -- it failed almost right away, not anywhere in the amarok build -- but I can't really make any sense of it.

@FRidh
Copy link
Member

FRidh commented Jul 15, 2016

do you still want to merge this following the further discussion in #15264 ?

@jerith666
Copy link
Contributor Author

I think it's worthwhile to have this interim solution, yes. Once there's a permanent fix in #15264 (or elsewhere), it can be rolled back.

@dezgeg
Copy link
Contributor

dezgeg commented Mar 18, 2017 •
edited

As far as I know this has been properly solved by #17413. Closing.

@dezgeg dezgeg closed this Mar 18, 2017
@jerith666
Copy link
Contributor Author

jerith666 commented Mar 22, 2017 •
edited

I think I agree, though it's hard to say for sure since #16588 still blocks using amarok at all for me. At least, I can say that reverting this commit and running with the debug flags from that issue, I don't see the error reported in #15264, but instead see:

amarok:           [CollectionManager] initializing "amarok_collection-mysqlecollection" 
amarok:           [MySqlStorage] Connected to MySQL server 10.1.21-MariaDB-embedded 
amarok:           Connected to MySQL server 10.1.21-MariaDB-embedded 
amarok:           [MySqlStorage] Initialized thread, count== 1

... which looks right.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Amarok is unusable
3 participants
@jerith666 @FRidh @dezgeg