FileUtils#rm_r removes a symlink itself #2928
Merged
+26
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Good catch! What about a distinct |
mosop
force-pushed
the
rm_r_removes_symlink_itself
branch
from
27f8744 to
cf89ce4
Compare
|
@ysbaddaden Thank you. How about my new spec? |
| File.write(file_path, "") | ||
|
|
||
| FileUtils.rm_r(removed_path) | ||
| Dir.exists?(removed_path).should be_false |
There was a problem hiding this comment.
You don't need to test that it removed a directory (the test above did that), just that the link itself got removed but not the destination folder nor its contents.
|
@ysbaddaden I can remove the line, but I think it is still needed to assert that rm_r successfully removes a directory even if it has symlinks. Because the older test is not asserting that. Confirm this again. Thanks. |
|
@mosop ok |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is for fix and improvement both.
If a directory have a symbolic link,
FileUtils#rm_rfails with an error message like:And if the symlink also points to a directory, rm_r also deletes all files under the directory. I feel it's a bit dangerous. The
rmcommand and Ruby'sFileUtils#rm_rremove a symlink itself instead.Thank you!