Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the order of output in "no overload matches" error #2876

Closed
wants to merge 1 commit into from

Conversation

oprypin
Copy link
Member

@oprypin oprypin commented Jun 18, 2016

def test(a : Int8 = 0)
end

test(5)

Before (invalid syntax in error message):

no overload matches 'test' with type Int32
Overloads are:
 - test(a = 0 : Int8)

After:

 - test(a : Int8 = 0)

@jhass
Copy link
Member

jhass commented Jun 18, 2016

Good catch! @asterite 0.18.3?

@asterite asterite added this to the 0.18.3 milestone Jun 19, 2016
@asterite
Copy link
Member

@jhass I tried merging this into release/0.18 following GitHub's instructions (clicking on "command line instructions"), but when I do that I get like 50 commits. What am I doing wrong?

@jhass
Copy link
Member

jhass commented Jun 20, 2016

Yes you can't just merge a branch based on master, you have to am it (basically cherry pick all the commits). The easiest is to use http://github.com/github/hub and then hub am -3 https://github.com/crystal-lang/crystal/pull/2876

@kostya
Copy link
Contributor

kostya commented Jun 20, 2016

i usually use this https://gist.github.com/piscisaureus/3342247, and merge, rebase by hands

@asterite
Copy link
Member

Merged in f5f5705

Thank you @BlaXpirit !

And thank you @jhass and @kostya for the advise. I ended up using hub, which I already had installed, it was super easy :-)

@asterite asterite closed this Jun 20, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants