Remove contracts.ruby as runtime dependency

nanoc · Jun 19, 2016 · e256df3 · e256df3
1 parent e343195
commit e256df3
Show file tree

Hide file tree

Showing 6 changed files with 52 additions and 13 deletions.
diff --git a/Gemfile b/Gemfile
@@ -3,6 +3,7 @@ source 'https://rubygems.org'
 gemspec
 
 group :devel do
+  gem 'contracts', '~> 0.14'
   gem 'coveralls', require: false
   gem 'guard-rake'
   gem 'fuubar'

diff --git a/lib/nanoc.rb b/lib/nanoc.rb
@@ -33,7 +33,6 @@ def self.on_windows?
 require 'time'
 require 'yaml'
 require 'English'
-require 'contracts'
 
 # Load Nanoc
 require 'nanoc/version'

diff --git a/lib/nanoc/base/contracts_support.rb b/lib/nanoc/base/contracts_support.rb
@@ -1,17 +1,60 @@
+require 'singleton'
+
 module Nanoc::Int
   # @api private
   module ContractsSupport
-    def self.included(base)
-      return if base.include?(::Contracts::Core)
+    class Ignorer
+      include Singleton
+
+      def method_missing(*_args)
+        self
+      end
+    end
+
+    module DisabledContracts
+      Any         = Ignorer.instance
+      Bool        = Ignorer.instance
+      Num         = Ignorer.instance
+      KeywordArgs = Ignorer.instance
+      Optional    = Ignorer.instance
+      Maybe       = Ignorer.instance
+      None        = Ignorer.instance
+      ArrayOf     = Ignorer.instance
+      Or          = Ignorer.instance
+      Func        = Ignorer.instance
+      RespondTo   = Ignorer.instance
 
-      base.include(::Contracts::Core)
-      base.extend(self)
-      base.const_set('C', ::Contracts)
+      def contract(*args)
+      end
     end
 
-    def contract(*args)
-      return unless ENV['CONTRACTS'] || $CONTRACTS
-      Contract(*args)
+    module EnabledContracts
+      def contract(*args)
+        Contract(*args)
+      end
+    end
+
+    def self.included(base)
+      contracts_loadable =
+        begin
+          require 'contracts'
+          true
+        rescue LoadError
+          false
+        end
+
+      should_enable = contracts_loadable && !ENV.key?('DISABLE_CONTRACTS')
+
+      if should_enable
+        unless base.include?(::Contracts::Core)
+          base.include(::Contracts::Core)
+          base.extend(EnabledContracts)
+          base.const_set('C', ::Contracts)
+        end
+      else
+        base.extend(DisabledContracts)
+        base.const_set('C', DisabledContracts)
+      end
     end
   end
 end
diff --git a/nanoc.gemspec b/nanoc.gemspec
@@ -25,7 +25,6 @@ Gem::Specification.new do |s|
   s.required_ruby_version = '>= 2.1.0'
 
   s.add_runtime_dependency('cri', '~> 2.3')
-  s.add_runtime_dependency('contracts', '~> 0.14')
 
   s.add_development_dependency('bundler', '>= 1.7.10', '< 2.0')
 end
diff --git a/spec/spec_helper.rb b/spec/spec_helper.rb
@@ -1,5 +1,3 @@
-$CONTRACTS = true
-
 require 'simplecov'
 SimpleCov.start
 

diff --git a/test/helper.rb b/test/helper.rb
@@ -1,5 +1,4 @@
 $VERBOSE = false
-$CONTRACTS = true
 
 require 'simplecov'
 SimpleCov.start