Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Name Nihonium, Moscovium, Tennessine, and Oganesson. #206

Closed
wants to merge 2 commits into from

Conversation

johnmay
Copy link
Member

@johnmay johnmay commented Jun 9, 2016

No description provided.

@johnmay
Copy link
Member Author

johnmay commented Jun 9, 2016

Ready for when they're approved. Just have to wait two months :-)

@egonw
Copy link
Member

egonw commented Aug 16, 2016

John, if you split this patch in file (whitespace) restructing and the actual addition, the first can be applied now, and the latter becomes a whole lot simpler (smaller), increasing the chance it still applies this autumn...

@johnmay
Copy link
Member Author

johnmay commented Aug 16, 2016

Done

@egonw
Copy link
Member

egonw commented Aug 17, 2016

OK, the first patch is now applied to master. Thanks!

@egonw
Copy link
Member

egonw commented Nov 30, 2016

There is news from IUPAC, I heard: https://twitter.com/Larsohrstrom/status/803871908236296192

@egonw
Copy link
Member

egonw commented Nov 30, 2016

@johnmay, I can resolve the conflicts here... unless you want to rebase the patches yourself? Plz let me know...

@johnmay
Copy link
Member Author

johnmay commented Nov 30, 2016

I'll fix the conflicts... actually bad names but they knew (read the document).

Ts is normally used for Tosyl, they say a chemist would never confuse the two but of course teaching a computer that is a little more tricky... well other than to just banning it's use.

Nh is more fun... consider [Nh] ins SMARTS used be aliphatic nitrogen with one implicit hydrogen. I think probably the fix here is ban the bottom rows from SMARTS symbols and suggest using '#' syntax instead.

@egonw
Copy link
Member

egonw commented Nov 30, 2016

Oh, wonderful points! @rajarshi, what do you think? Should we invite @johnmay for a JCheminf Commentary (http://jcheminf.springeropen.com/submission-guidelines/preparing-your-manuscript/commentary) to write up the implications to cheminformatics (i.e. outlining some of the (open) standards that need updating? I'd be happy with even shorter than 800 words...

@rajarshi
Copy link
Member

Yes, that would certainly be welcome. @johnmay raises a good point - standards committees might consult with informatics to ensure that they're standards don't impede informatics handling

@johnmay
Copy link
Member Author

johnmay commented Nov 30, 2016 via email

@egonw egonw closed this Nov 30, 2016
@egonw egonw reopened this Nov 30, 2016
@egonw
Copy link
Member

egonw commented Nov 30, 2016

(oops, wrong button)

@johnmay johnmay closed this Dec 13, 2016
@johnmay johnmay deleted the patch/2016elements branch December 13, 2016 15:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants