Windows check should come first as the O_NONBLOCK does work under win… #3958
+4
−9
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi Reviewer,
Sudish reported a bug in JRuby running under Windows 7, Issue: #3332
I am currently running cucumber-jruby on various platforms and only under windows do I get this problem.
The fix is trivial, just check that the system is windows first before making any further checks.
Thanks Sudish for making it easy to fix.
I removed commented out code also, as the logic was if something then if not something do nothing. Kind of stoopid.