Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Windows check should come first as the O_NONBLOCK does work under win… #3958

Closed
wants to merge 1 commit into from
Closed

Conversation

SquirrelGrip
Copy link

Hi Reviewer,

Sudish reported a bug in JRuby running under Windows 7, Issue: #3332

I am currently running cucumber-jruby on various platforms and only under windows do I get this problem.

The fix is trivial, just check that the system is windows first before making any further checks.

Thanks Sudish for making it easy to fix.

I removed commented out code also, as the logic was if something then if not something do nothing. Kind of stoopid.

@headius
Copy link
Member

headius commented Jun 28, 2016

The commented code was there as a "todo" for getting Windows support improved in recently-ported MRI logic.

I mentioned on #3332 that the error produced should not happen on a properly built JRuby. There must be a stale version of jnr-constants causing that error, because JRuby wouldn't even compile if that method does not exist.

Can you explain the environment where you see this error? Something's wrong there.

@headius
Copy link
Member

headius commented Jun 28, 2016

Also, sorry for the delay getting back to you, @SquirrelGrip :-)

@SquirrelGrip
Copy link
Author

Hi Headius, Sorry for also taking a while to get back. I had a look into what you said and revisited the problem. I am now unable to reproduce when I started again.
I think I may have had an environment issue and suspect that I had an older version of JRuby on the path and with my pom I had the latest version.
Thanks for looking into it.
I will revert if I discover any more information for others.

@headius
Copy link
Member

headius commented Jul 11, 2016

I will close this and #3332 until you or @sudish can reproduce. Thanks for getting back to us!

@headius headius closed this Jul 11, 2016
@headius headius added this to the Invalid or Duplicate milestone Jul 11, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants