Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
artiq_flash: explicitly pass path within conda env to openocd dataroo…
…tdir. By default, openocd searches for scripts in DATAROOTDIR/openocd/scripts. This of course makes it not relocatable. Conda has a flag to try to detect and fix such hardcoded paths, but it does not work on openocd (likely because the .rodata contains an already concatenated path, which cannot be padded with zeroes from the right). So, we pass the path explicitly instead.
57be065
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Won't this break on non-conda installs?
57be065
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nope. It just adds another search path (which may or may not exist).
57be065
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree that this is not an especially clean fix, but I don't see a much better way short of making openocd properly relocatable (which would go against autoconf conventions and probably rejected by upstream).