Make the system
macro call set the current working directory
#2784
+4
−3
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2750
I think it makes more sense. If I have:
{{ `cat foo.txt`.stringify }}
I'd expect "foo.txt" to be relative to the file where the macro is defined. This makes builds reproducible, which doesn't happen right now because this basically depends on the current working directory where the program is compiled.
I know that
__DIR__
can be used, but when dealing with files it will always have to be used, which makes things more verboise and harder to understand.