-
-
Notifications
You must be signed in to change notification settings - Fork 925
Permalink
Choose a base ref
{{ refName }}
default
Choose a head ref
{{ refName }}
default
Comparing changes
Choose two branches to see what’s changed or to start a new pull request.
If you need to, you can also or
learn more about diff comparisons.
Open a pull request
Create a new pull request by comparing changes across two branches. If you need to, you can also .
Learn more about diff comparisons here.
base repository: jruby/jruby
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: 2bfa81cf7733
Could not load branches
Nothing to show
Loading
Could not load tags
Nothing to show
{{ refName }}
default
Loading
...
head repository: jruby/jruby
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: 468b4e3ef0da
Could not load branches
Nothing to show
Loading
Could not load tags
Nothing to show
{{ refName }}
default
Loading
- 4 commits
- 8 files changed
- 1 contributor
Commits on Jun 28, 2016
-
Configuration menu - View commit details
-
Copy full SHA for 3fe3a18 - Browse repository at this point
Copy the full SHA 3fe3a18View commit details -
Add new mechanism for visiting all Hash elements without alloc.
This new mechanism passes in state that makes most Visitor construction unnecessary: thread context, currently-visiting Hash, and a generic state object.
Configuration menu - View commit details
-
Copy full SHA for 7da1d22 - Browse repository at this point
Copy the full SHA 7da1d22View commit details
Commits on Jun 29, 2016
-
Use new visitor logic everywhere.
Nearly all of these are now allocated once, like a lambda. A few require more state to be passed in than is reasonable for a generic visitor, or require state to be calculated during visit and retrieved at the end. These cases were at least reduced to only allocate a visitor, rather than a visitor and a state-holding object.
Configuration menu - View commit details
-
Copy full SHA for 021c19b - Browse repository at this point
Copy the full SHA 021c19bView commit details -
Deprecate old visitAll to prevent mix-ups.
See MapJavaProxy's RubyHashMap subclass; it previously override the old visitAll, which broke Map instances returned from Java because that visitAll was not being used. This will help ensure no subclasses are overriding the wrong method. I don't expect there's many (or maybe any) other cases in the wild.
Configuration menu - View commit details
-
Copy full SHA for 468b4e3 - Browse repository at this point
Copy the full SHA 468b4e3View commit details
There are no files selected for viewing