Add horizontal scrollbar to listings #2383
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I prefer the first one. The main point of having a design is readability, which is hard in the second design even if it's a single line. |
|
Aren't these horizontal scrolling bars? |
Kwpolska
changed the title
|
Oops, one typo that went everywhere. Should be fixed everywhere. |
Via getnikola/nikola-themes#86 Signed-off-by: Chris Warrick <kwpolska@gmail.com>
Kwpolska
force-pushed
the
listing-overflow
branch
from
9439405
to
537ec48
Compare
|
Merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This replaces code tables that would go beyond screen width with code tables that always have horizontal scrollbars. This is not a perfect solution, though — it looks uglier when there is no overflow:
There’s also
overflow-x: overlay;which looks like this and partially covers text:Which one is better for most users? Opinions welcome.
cc @iAmMrinal0 — via getnikola/nikola-themes#86 (pending)