Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: crystal-lang/crystal
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: 88bd6d0bc985
Choose a base ref
...
head repository: crystal-lang/crystal
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: 5a6ca7c8e7d3
Choose a head ref
  • 3 commits
  • 3 files changed
  • 1 contributor

Commits on Jun 13, 2016

  1. Build standard library specs with the currently released compiler first

    @jhass
    jhass committed Jun 13, 2016
    Copy the full SHA
    07ec028 View commit details

  2. Fix standard library specs for Crystal 0.17.4

    @jhass
    jhass committed Jun 13, 2016
    Copy the full SHA
    d9166fa View commit details

  3. Merge pull request #2825 from jhass/stdlib_specs_prev 

    Build standard library specs with the currently released compiler first
    @jhass
    jhass authored Jun 13, 2016
    Copy the full SHA
    5a6ca7c View commit details
Showing with 9 additions and 4 deletions.
  1. +1 −0 .travis.yml
  2. +4 −2 spec/std/named_tuple_spec.cr
  3. +4 −2 spec/std/tuple_spec.cr
1 change: 1 addition & 0 deletions .travis.yml
View file
Original file line number Diff line number Diff line change
@@ -15,6 +15,7 @@ matrix:
before_install: bin/ci prepare_system
install: bin/ci prepare_build
script:
- bin/ci with_build_env 'make std_spec clean'
- bin/ci with_build_env 'make crystal std_spec compiler_spec doc'
- bin/ci with_build_env 'find samples -name "*.cr" | xargs -L 1 ./bin/crystal build --no-codegen'
- bin/ci with_build_env './bin/crystal tool format --check'
6 changes: 4 additions & 2 deletions spec/std/named_tuple_spec.cr
View file
Original file line number Diff line number Diff line change
@@ -28,7 +28,8 @@ describe "NamedTuple" do
NamedTuple(foo: Int32, bar: Int32).from({:foo => 1, :baz => 2})
end

expect_raises(TypeCastError, /cast from String to Int32 failed/) do
# TODO: simplify regex and use TypeCastError after 0.18
expect_raises(Exception, /cast (?:from String )?to Int32 failed/) do
NamedTuple(foo: Int32, bar: Int32).from({:foo => 1, :bar => "foo"})
end
end
@@ -50,7 +51,8 @@ describe "NamedTuple" do
{foo: Int32, bar: Int32}.from({:foo => 1, :baz => 2})
end

expect_raises(TypeCastError, /cast from String to Int32 failed/) do
# TODO: simplify regex and use TypeCastError after 0.18
expect_raises(Exception, /cast (?:from String )?to Int32 failed/) do
{foo: Int32, bar: Int32}.from({:foo => 1, :bar => "foo"})
end
end
6 changes: 4 additions & 2 deletions spec/std/tuple_spec.cr
View file
Original file line number Diff line number Diff line change
@@ -155,7 +155,8 @@ describe "Tuple" do
Tuple(Int32).from([1, 2])
end

expect_raises(TypeCastError, /cast from String to Int32 failed/) do
# TODO: simplify regex and use TypeCastError after 0.18
expect_raises(Exception, /cast (?:from String )?to Int32 failed/) do
Tuple(Int32, String).from(["foo", 1])
end
end
@@ -169,7 +170,8 @@ describe "Tuple" do
{Int32}.from([1, 2])
end

expect_raises(TypeCastError, /cast from String to Int32 failed/) do
# TODO: simplify regex and use TypeCastError after 0.18
expect_raises(Exception, /cast (?:from String )?to Int32 failed/) do
{Int32, String}.from(["foo", 1])
end
end