New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add nixpkgs documentation about how to create a derivation with Vim plugins #16501
Conversation
By analyzing the blame information on this pull request, we identified @vcunat, @edolstra and @ericsagnes to be potential reviewers |
@@ -0,0 +1,102 @@ | |||
--- | |||
title: User's Guide for Vim in Nixpkgs | |||
author: Peter Simons |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copy pasta author? (I'm guessing the author is Marc?)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@MarcWeber ping
|
||
Then run | ||
|
||
nix-shell -p vimUtils.vim_with_vim2nix --command "vim -c 'source generate.vim'" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am trying this on NixOS unstable, but I am getting:
error: attribute ‘vim_with_vim2nix’ missing, at (string):1:66
(use ‘--show-trace’ to show detailed location information)
When trying to launch this command.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That is defined in this very PR at https://github.com/NixOS/nixpkgs/pull/16501/files#diff-f10fa9becd39f0389d86d6d4963cb1a1R369.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
haaa OK my bad... I should have been more careful to check the patch for actual nix code change.
Any progress here? I think we can merge this as-is, can't we? |
Looks OK to me, after fixing the author :-) |
Thanks @MarcWeber! (I somehow missed this half a year ago.) |
No description provided.