Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix benchmark spec #2833

Merged
merged 1 commit into from
Jun 14, 2016
Merged

Fix benchmark spec #2833

merged 1 commit into from
Jun 14, 2016

Conversation

will
Copy link
Contributor

@will will commented Jun 14, 2016

references commit 3259b71

# timer precisison sleep 0.001 may not always be faster than 0.002 so we
# don't care which
first, second = [a.slower, b.slower].sort
first.should eq(1)
b.slower.should be > 1
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So this should be second.slower?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes thanks. It's in my editor but I forgot a :w :<

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

updated

@will will force-pushed the benchmark-spec branch from c0def60 to c0dea0a Compare June 14, 2016 20:33
references commit 3259b71
@asterite
Copy link
Member

Did you stop drinking coffee and started to c0de? :-)

@will
Copy link
Contributor Author

will commented Jun 14, 2016

My first exactly 50 commits were cafe, then I switched to c0de for the next 50 :)

@jhass jhass merged commit bc1f0f2 into crystal-lang:master Jun 14, 2016
@jhass
Copy link
Member

jhass commented Jun 14, 2016

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants